Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MIME_TYPES #764

Merged
merged 1 commit into from
May 9, 2024
Merged

Deprecate MIME_TYPES #764

merged 1 commit into from
May 9, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 8, 2024

This code wasn't actually necessary, as demonstrated by the fact that the new test passes both with and without the changes to src/main. And since it would otherwise need to change for Jetty 12, simplest to delete it rather than adapt it for Jetty 12. This PR begins the process by deprecating it and removing consumption from this repository. A GitHub code search shows that there are a handful of consumers that aren't doing anything interesting. I will file some PRs to adapt the ones in jenkinsci/.

Testing done

New test passes both with and without the changes to src/main.

@basil basil merged commit b6072d5 into jenkinsci:master May 9, 2024
14 checks passed
@basil basil deleted the mime-type branch May 9, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants