-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-21613] f:combobox may break form.onsubmit #1111
[JENKINS-21613] f:combobox may break form.onsubmit #1111
Conversation
core » jenkins-core #116 SUCCESS |
This JENKINS-21613 becomes annoying in the case of using "Apply" hotkey. +1 |
retriggering the PR. |
I might misunderstood your comment. Anyway, new plugins should use |
@oleg-nenashev Ping Also, @jenkinsci/code-reviewers |
@ikedam @daniel-beck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason why we keep it unmerged.
Retriggering CI |
@ikedam Could you please re-merge with the master to retrigger CI? https://ci.jenkins.io/job/Core/job/jenkins/job/PR-1111/9/console IIUC one cannot just retrigger it after the recent changes in PR handling by @rtyler and @daniel-beck |
I don't understand the problem well enough to have an opinion on this. |
On hold till it's remerged with master |
…just before override.
9f45ffd
to
d0ff413
Compare
Rebased to master (no conflicts) to re-trigger the CI.
|
@ikedam Could you provide an example how the previous implementation could lead to problems? It's unclear to me how this works. |
@daniel-beck This issue can cause a problem when a component (component X) tries to hook
This can be fixed in any of following ways: A. Uses I found this issue when I developed the first version of extensible-choice-parameter-plugin. I fixed that problem in the way same to this request and wanted to apply the same change to core as it seemed a fundamentally unsafe behavior even though there’re workarounds as described above. |
@ikedam Thanks for the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, reconfirm my feedback
f:combobox prevents form submission when the dropdown is open.
This is done by interrupting form.onsubmit.
It handles form.onsubmit in the following way:
If the form.onsubmit was overridden between step 1 and 2, it would be overridden in step 3 and lost.
This change saves the original onsubmit handler just before overriding it.