Fix for JENKINS-22425, still needs license fix.

[bhamail]

I have a fix ready for: https://issues.jenkins-ci.org/browse/JENKINS-22425
The fix just added a new required method (getFieldOrder()) on Structure sub classes. The fix also upgrades to the latest released version of JNA (4.1.0).

I'm having a problem with cloud bees:maven-license-plugin complaining about an unexpected license after updating to the latest release of JNA (4.1.0 from 3.3.0-jenkins-3):

[INFO] Reactor Summary:
[INFO]
[INFO] Jenkins main module ............................... SUCCESS [ 5.015 s]
[INFO] Jenkins CLI ....................................... SUCCESS [ 12.483 s]
[INFO] Jenkins core ...................................... SUCCESS [02:54 min]
[INFO] Jenkins war ....................................... FAILURE [ 17.299 s]
[INFO] Test harness for Jenkins and plugins .............. SKIPPED
[INFO] Jenkins plugin POM ................................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:33 min
[INFO] Finished at: 2014-04-09T22:30:13-05:00
[INFO] Final Memory: 199M/475M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.cloudbees:maven-license-plugin:1.7:process (default) on project jenkins-war: Execution default of goal com.cloudbees:maven-license-plugin:1.7:process failed: java.lang.IllegalStateException: Expecting [] but found [LGPL, version 2.1,ASL, version 2] for dependency net.java.dev.jna:jna:4.1.0 -> [Help 1]

Any suggestions on how I can fix this error?

[cloudbees-pull-request-builder]

core » jenkins-core #459 FAILURE
Looks like there's a problem with this pull request

[daniel-beck]

Probably just needs to be removed from licenseCompleter.groovy.

[olivergondza]

You seem to bump version from jenkinsci fork to upstream (that is using dual licensing since 4.0). Are we really ready to switch to upstream version?

[bhamail]

I have fixed the license issue. (Thanks for the pointer Daniel).

I don't know of a reason not to use the upstream version.

[cloudbees-pull-request-builder]

core » jenkins-core #465 UNSTABLE
Looks like there's a problem with this pull request

[daniel-beck]

Jenkins fork appears to be limited to JNA-184 (apparently fixed in 3.4.0?) and JENKINS-10774. At least these need to be tested.

[oleg-nenashev]

Also would fix https://issues.jenkins-ci.org/browse/JENKINS-13298 (just a JNA update request)

[daniel-beck]

The fix just added a new required method (getFieldOrder()) on Structure sub classes

Are plugins able to use core's JNA? If so, this looks like an incompatible change.

[daniel-beck]

Is this still active?

[bhamail]

I had intended to verify using the latest jna did not cause other issues, but haven't had the chance yet. Is there a way to get github/cloudbees to rerun the 'pull-request-builder'? The prior 'Unstable' link is no longer working, and I'd like to see what the problem is.

[daniel-beck]

Try git commit --amend and confirm the previous commit message, that should update just the timestamp. Then git push -f … to force updating your fork on Github and the PR will be considered refreshed.

[iMichka]

Yes it would be nice if this could be fixed, I really would like to run Jenkins on my ARM powered Cubietruck :).

[rodrigc]

Upgrading to JNA 4.1.0 seems to fix multiple platforms. I have filed a separate
issue: https://issues.jenkins-ci.org/browse/JENKINS-24521 and
pull request: #1387

My pull request is basically the same as this one.

Can we collaborate on testing? I don't have access to all the different platforms.

@iMichka : can you help test on Linux on ARM?
@oleg-nenashev : can you help test on Linux on PowerPC?

I have a war file compiled from my pull request:

http://people.freebsd.org/~rodrigc/jenkins/JENKINS-24251/

Can you help with testing?

[jglick]

Is there a way to get github/cloudbees to rerun the 'pull-request-builder'?

The usual way is to

git fetch origin && git merge origin/master && git push

[rodrigc]

@bhamail: Look at https://github.com/rodrigc/jenkins/commit/50a85b18046f8f3a72ea2c0e98ed89f04c6c15c2
licenseCompleter.groovy needs to be patched if you update Jenkins to JNA 4.1.0

[rodrigc]

This pull request is superseded by #1387

[kohsuke]

Merged PR #1387, so closing this.