Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically align setting-name class to middle #175

Closed
wants to merge 1 commit into from

Conversation

kevinsawicki
Copy link
Contributor

This will align the name to the left of the fields to be centered instead of top aligned.

Before

After

@kohsuke
Copy link
Member

kohsuke commented Jun 24, 2011

Bravo! Thank you!

BTW, shouldn't you have the push access so that you can make changes like this directly in the master branch?

@kohsuke kohsuke closed this Jun 24, 2011
@kevinsawicki
Copy link
Contributor Author

I don't currently have push access, but I would like it if that is an option.

@kohsuke
Copy link
Member

kohsuke commented Jun 24, 2011

Push access is available to anyone who's interested in having one.
The only thing we need to check with you is to see if you'd be willing to sign CLA or if you'll likely have a problem with it. Please see https://wiki.jenkins-ci.org/display/JENKINS/Copyright+on+source+code

@uhafner uhafner reopened this Jul 8, 2011
@uhafner
Copy link
Member

uhafner commented Jul 8, 2011

This looks really nice for single entriy fields but not for multi-line feeds. Do you think it's possible to change that for these fields?

See https://issues.jenkins-ci.org/browse/JENKINS-10253.

@bap2000
Copy link
Member

bap2000 commented Jul 10, 2011

Yes, this has two major issues with multiline, or nested entries.

  1. It is impossible to see which of the nested fields belong to which label - with top alignment, everything from the label to just above the following label belongs to that entry - with middle alignment, the separator is somewhere between the two lables, but with no way of knowing where.
  2. When you expand an advanced section, the entry becomes bigger, and the label jumps to the new half way point, this is distracting as it draws your attention to something that has not added anything new to the form.

@kohsuke
Copy link
Member

kohsuke commented Jul 13, 2011

This change was reverted in 5936e97.

Maybe there's some behaviour rule, Jelly magic, or CSS tricks to make this vertical-alignment kick in only for "simple" entries? I'm closing this pull request for now.

@kohsuke kohsuke closed this Jul 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants