Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-33659 - Basic fix for scrollspy width issues #2153

Merged
merged 1 commit into from
Mar 23, 2016
Merged

JENKINS-33659 - Basic fix for scrollspy width issues #2153

merged 1 commit into from
Mar 23, 2016

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Mar 22, 2016

A trivial fix for the config page to prevent wide input fields from breaking out of the UI and allowing use of much of the screen (currently 90%-100%).

image

image

As opposed to currently:

image

@oleg-nenashev
Copy link
Member

🐝

@kzantow
Copy link
Contributor Author

kzantow commented Mar 22, 2016

@reviewbybees esp. @gusreiber -- note there is a case if the container is wide and the page scrolled down and right that the tabs no longer line up, however with this scroll-tab design I think this is preferable to the alternative, since they remain usable and onscreen.

@ghost
Copy link

ghost commented Mar 22, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@tfennelly
Copy link
Member

@kzantow From looking at the screenshots, it looks like there's a left margin, but no right margin, yeah? That looks a bit strange to me.

@jglick
Copy link
Member

jglick commented Mar 22, 2016

The left margin without right margin does look a bit odd, but 🐝 based on the screenshots (have not tried it).

@kzantow
Copy link
Contributor Author

kzantow commented Mar 22, 2016

@tfennelly there's both left and right margin. The UI had an issue where the container did not expand to the contents in the case where something inside was wider than the width of the box (which was set to 75em), for example the script editor extending beyond the page width as shown in the second screenshot.

@kzantow
Copy link
Contributor Author

kzantow commented Mar 22, 2016

@jglick @tfennelly agree, it's a bad case where the script editor is very wide, in "most" cases it will have equal margins on both sides as is pictured in the first screenshot

@kzantow kzantow self-assigned this Mar 22, 2016
@daniel-beck
Copy link
Member

👍 Would be better if the text area never resized horizontally in the first place, but this is definitely an improvement over the current situation.

@daniel-beck daniel-beck merged commit 6a355ae into jenkinsci:2.0 Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants