Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-38301] Add configuration for disabling admin monitors #2546

Merged

Conversation

daniel-beck
Copy link
Member

Also add display name for all admin monitors in core.

Screenshots:

Screen shot 1

screen shot 2

@reviewbybees

Add display name for all admin monitors in core.
@abayer
Copy link
Member

abayer commented Sep 17, 2016

🐝

@ghost
Copy link

ghost commented Sep 17, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@daniel-beck daniel-beck changed the title Add configuration for disabling admin monitors [FIX JENKINS-38301] Add configuration for disabling admin monitors Sep 17, 2016
@daniel-beck daniel-beck added the needs-more-reviews Complex change, which would benefit from more eyes label Sep 17, 2016
@KostyaSha
Copy link
Member

KostyaSha commented Sep 20, 2016

👍 LGTM, good field for user interaction improvements!

@stephenc
Copy link
Member

🐝

@daniel-beck daniel-beck merged commit 123d224 into jenkinsci:master Sep 20, 2016
@daniel-beck daniel-beck removed the needs-more-reviews Complex change, which would benefit from more eyes label Sep 20, 2016

@Extension
@Restricted(NoExternalUse.class)
public class AdministrativeMonitorsConfiguration extends GlobalConfiguration {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @since

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants