[JENKINS-42969] UnsupportedOperationException from Computer.addAction #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Mar 21, 2017
| super.getActions().add(a); | ||
| } | ||
|
|
||
| // TODO implement addOrReplaceAction, removeAction, removeActions, replaceActions |
There was a problem hiding this comment.
These were introduced in #2608 so there is no compatibility issue: they would never have worked on Computer.
| @@ -106,6 +106,8 @@ public String getExpression() { | |||
| return Collections.unmodifiableList(actions); | |||
| } | |||
|
|
|||
| // TODO implement addAction, addOrReplaceAction, removeAction, removeActions, replaceActions | |||
There was a problem hiding this comment.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
oleg-nenashev
approved these changes
Mar 22, 2017
oleg-nenashev
added
the
needs-more-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See JENKINS-42969. Corrects a regression in #2624. Worked around in jenkinsci/ssh-agents-plugin#50.
Changelog entries
Proposed changelog entries:
Computer.addActionwould throw anUnsupportedOperationExceptionsince Jenkins 2.30. Such a call site was released in SECURITY-161.Desired reviewers
@reviewbybees