Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47139] Fix setup wizard #3050

Merged
merged 1 commit into from Sep 27, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 27, 2017

See JENKINS-47139. Amends #3010.

  • fix (passes InstallWizardTest.wizardInstallSugestedTest)
  • verify that JENKINS-42577 is still fixed

Proposed changelog entries

  • Jenkins 2.80 introduced a regression preventing the setup wizard from being run on new installations, and thus allowing Jenkins to run without security.

Desired reviewers

@reviewbybees @jenkinsci/code-reviewers

…, lest InstallUtil.getLastExecVersion get confused.
@ghost
Copy link

ghost commented Sep 27, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@daniel-beck daniel-beck added needs-more-reviews Complex change, which would benefit from more eyes regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels Sep 27, 2017
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@oleg-nenashev
Copy link
Member

@reviewbybees done

@jglick jglick added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Sep 27, 2017
@jglick jglick merged commit 77785be into jenkinsci:master Sep 27, 2017
@jglick jglick deleted the setup-wizard-version-JENKINS-47139 branch September 27, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
4 participants