Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-31661] Check the root url (Admin monitor + Wizard) #3082
The problem is that the application has some little issues when there is no rootURL configured. Example: JENKINS-47426.
There was already a PR (#1921) for the issue but as the PR went too far in the correction it was not merged (as I understand). This PR focuses only on the monitor part.
Proposed changelog entries
I just tried with the PR build: Going through the setup wizard leaves Jenkins without a defined root URL.
While I think this admin monitor is a good idea, Jenkins should not be showing warnings (other than "newer Jenkins is available") to someone who just went through the setup wizard.
For that reason, I strongly disagree with merging this change as is. The setup wizard should be extended to allow defining a Jenkins URL (or could perhaps infer one from the URL used to access Jenkins in the setup wizard, similar to how the form field determines its default value?).
Only then would this change make sense.
dwnusbaum left a comment
Small comments about some of the wording but looks fine to me in general.
I am somewhat against adding a new dependency but if