[JENKINS-57855] read-only flag of folders on windows #4059
Conversation
On windows the current way of removing the read only flag is not working for folders. Using the Files api this can be solved.
| if (dos != null) | ||
| { | ||
| dos.setReadOnly(false); | ||
| } |
There was a problem hiding this comment.
Should it handle the SecurityException and wrap it into IOException? https://docs.oracle.com/javase/7/docs/api/java/nio/file/attribute/DosFileAttributeView.html#setReadOnly(boolean)
There was a problem hiding this comment.
Then we would need to wrap almost all File stuff in this class.
| * If on Windows a folder has a read only attribute set, the file.setWritable(true) doesn't work (JENKINS-57855) | ||
| */ | ||
| DosFileAttributeView dos = Files.getFileAttributeView(path, DosFileAttributeView.class, LinkOption.NOFOLLOW_LINKS); | ||
| if (dos != null) |
There was a problem hiding this comment.
Is it supposed to fall through and call path.toFile().setWritable(true); in such case? Looks so
There was a problem hiding this comment.
I would assume that it is not necessary to call the setWritable(true) for windows.
If this fails then the setWritable would also fail I guess.
There was a problem hiding this comment.
I think it is fine and ready to go. Thanks @mawinter69 !
Just to avoid future regressions, an Windows-only unit test could be created (Assume class allows to create optional tests in JUnit)
oleg-nenashev
added
the
ready-for-merge
|
I am going to merge it towards the next weekly if no negative feedback |
See JENKINS-57855.
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers