jenkinsci · timja · Jul 18, 2022 · Jun 26, 2022 · Jun 26, 2022 · Jun 26, 2022
diff --git a/core/src/main/java/jenkins/model/NewViewLink.java b/core/src/main/java/jenkins/model/NewViewLink.java
diff --git a/core/src/main/resources/jenkins/model/Messages.properties b/core/src/main/resources/jenkins/model/Messages.properties
@@ -61,8 +61,6 @@ JenkinsLocationConfiguration.does_not_look_like_an_email_address=Does not look l
 Mailer.Localhost.Error=Please set a valid host name, instead of localhost
 Mailer.NotHttp.Error=The URL is invalid, please ensure you are using http:// or https:// with a valid domain.
 
-NewViewLink.NewView=New View
-
 PatternProjectNamingStrategy.DisplayName=Pattern
 PatternProjectNamingStrategy.NamePatternRequired=Name Pattern is required
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=regular expression''s syntax is invalid.

diff --git a/core/src/main/resources/jenkins/model/Messages_de.properties b/core/src/main/resources/jenkins/model/Messages_de.properties
@@ -49,8 +49,6 @@ DefaultProjectNamingStrategy.DisplayName=keine Einschr\u00E4nkung
 Mailer.Address.Not.Configured=Adresse nicht konfiguriert <nobody@nowhere>
 Mailer.Localhost.Error=Bitte verwenden Sie einen konkreten Hostnamen anstelle von <code> localhost </code>.
 
-NewViewLink.NewView=Ansicht anlegen
-
 PatternProjectNamingStrategy.DisplayName=Muster
 PatternProjectNamingStrategy.NamePatternRequired=Der Regul\u00E4re Ausdruck darf nicht leer sein.
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=Der Regul\u00E4re Ausdruck ist ung\u00FCltig.

diff --git a/core/src/main/resources/jenkins/model/Messages_fr.properties b/core/src/main/resources/jenkins/model/Messages_fr.properties
@@ -53,4 +53,3 @@ BlockedBecauseOfBuildInProgress.shortDescription=Le build #{0} est d\u00e9j\u00e
 BlockedBecauseOfBuildInProgress.ETA=\ (fin pr\u00e9vue \u00e0 : {0})
 BuildDiscarderProperty.displayName=Supprimer les anciens builds
 
-NewViewLink.NewView=Cr\u00E9er une Vue
diff --git a/core/src/main/resources/jenkins/model/Messages_it.properties b/core/src/main/resources/jenkins/model/Messages_it.properties
@@ -72,7 +72,6 @@ Mailer.Address.Not.Configured=Indirizzo non ancora configurato \
 Mailer.Localhost.Error=Impostare un nome host valido anzich� localhost
 Mailer.NotHttp.Error=L''URL non � valido, assicurarsi di utilizzare http:// o \
   https:// con un dominio valido.
-NewViewLink.NewView=Nuova vista
 ParameterizedJobMixIn.build_now=Compila ora
 ParameterizedJobMixIn.build_with_parameters=Compila con parametri
 PatternProjectNamingStrategy.DisplayName=Pattern

diff --git a/core/src/main/resources/jenkins/model/Messages_ja.properties b/core/src/main/resources/jenkins/model/Messages_ja.properties
@@ -52,8 +52,6 @@ CLI.safe-shutdown.shortDescription=\
 
 DefaultProjectNamingStrategy.DisplayName=\u30c7\u30d5\u30a9\u30eb\u30c8
 
-NewViewLink.NewView=\u65b0\u898f\u30d3\u30e5\u30fc
-
 PatternProjectNamingStrategy.DisplayName=\u30d1\u30bf\u30fc\u30f3
 PatternProjectNamingStrategy.NamePatternRequired=\u30d1\u30bf\u30fc\u30f3\u306f\u5fc5\u9808\u3067\u3059\u3002
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=\u6b63\u898f\u8868\u73fe\u306b\u8aa4\u308a\u304c\u3042\u308a\u307e\u3059\u3002

diff --git a/core/src/main/resources/jenkins/model/Messages_ko.properties b/core/src/main/resources/jenkins/model/Messages_ko.properties
@@ -4,8 +4,6 @@ Hudson.ViewAlreadyExists="{0}" \uC774\uB984\uC758 \uBDF0\uAC00 \uC774\uBBF8 \uC8
 
 CLI.restart.shortDescription=Jenkins\uB97C \uC548\uC804\uD558\uAC8C \uC7AC\uC2DC\uC791
 
-NewViewLink.NewView=\uC0C8\uB85C\uC6B4 \uBDF0
-
 ParameterizedJobMixIn.build_with_parameters=\uD30C\uB77C\uBBF8\uD130\uC640 \uD568\uAED8 \uBE4C\uB4DC
 ParameterizedJobMixIn.build_now=\uC9C0\uAE08 \uBE4C\uB4DC
 BlockedBecauseOfBuildInProgress.shortDescription=\uBE4C\uB4DC #{0} \uAC00 \uC774\uBBF8 \uC9C4\uD589\uC911\uC785\uB2C8\uB2E4{1}

diff --git a/core/src/main/resources/jenkins/model/Messages_pt_BR.properties b/core/src/main/resources/jenkins/model/Messages_pt_BR.properties
@@ -62,7 +62,6 @@ Mailer.NotHttp.Error=A URL \u00E9 inv\u00E1lida, por favor se certifique que voc
   v\u00E1lido.
 Hudson.Computer.IncorrectNumberOfExecutors=Campo "N\u00FAmero de executores" incorreto. Ele precisa ser um n\u00FAmero n\u00E3o \
   negativo.
-NewViewLink.NewView=Nova vis\u00E3o
 EnforceSlaveAgentPortAdministrativeMonitor.displayName=Impor porta TCP para o agente
 BuiltInNodeMigration.DisplayName=Nome do n\u00F3 embutido e migra\u00E7\u00E3o de r\u00F3tulo
 SimpleGlobalBuildDiscarderStrategy.displayName=Descartador de constru\u00E7\u00E3o espec\u00EDfico

diff --git a/core/src/main/resources/jenkins/model/Messages_ru.properties b/core/src/main/resources/jenkins/model/Messages_ru.properties
@@ -55,4 +55,3 @@ PatternProjectNamingStrategy.NamePatternInvalidSyntax=\u041D\u0435\u043A\u043E\u
 ParameterizedJobMixIn.build_with_parameters=\u0421\u043E\u0431\u0440\u0430\u0442\u044C \u0441 \u043F\u0430\u0440\u0430\u043C\u0435\u0442\u0440\u0430\u043C\u0438
 CLI.disable-job.shortDescription=\u0417\u0430\u043F\u0440\u0435\u0442\u0438\u0442\u044C \u0437\u0430\u0434\u0430\u0447\u0443
 CLI.enable-job.shortDescription=\u0420\u0430\u0437\u0440\u0435\u0448\u0438\u0442\u044C \u0437\u0430\u0434\u0430\u0447\u0443
-NewViewLink.NewView=\u041d\u043e\u0432\u043e\u0435\u0020\u043f\u0440\u0435\u0434\u0441\u0442\u0430\u0432\u043b\u0435\u043d\u0438\u0435
diff --git a/core/src/main/resources/jenkins/model/Messages_tr.properties b/core/src/main/resources/jenkins/model/Messages_tr.properties
@@ -30,7 +30,6 @@ Hudson.NoJavaInPath=java, PATH i\u00e7erisinde de\u011fil. <a href=''{0}/configu
 Hudson.NoName=\u0130sim belirtilmedi
 Hudson.UnsafeChar=''{0}'' g\u00fcvenli olmayan bir karakter
 Hudson.ViewName=Hepsi
-NewViewLink.NewView=Yeni G\u00f6r\u00fcn\u00fcm
 ParameterizedJobMixIn.build_now=\u015eimdi Yap\u0131land\u0131r
 BlockedBecauseOfBuildInProgress.shortDescription=Yap\u0131land\u0131rma #{0} zaten i\u015flemde {1}
 BlockedBecauseOfBuildInProgress.ETA=\ (ETA: {0})

diff --git a/core/src/main/resources/jenkins/model/Messages_zh_TW.properties b/core/src/main/resources/jenkins/model/Messages_zh_TW.properties
@@ -55,8 +55,6 @@ JenkinsLocationConfiguration.does_not_look_like_an_email_address=\u9019\u770b\u8
 Mailer.Localhost.Error=\u8acb\u8a2d\u5b9a\u6709\u6548\u7684\u4e3b\u6a5f\u540d\u7a31\uff0c\u4e0d\u8981\u7528 localhost
 Mailer.NotHttp.Error=URL \u7121\u6548\uff0c\u8acb\u78ba\u4fdd\u60a8\u4f7f\u7528 http\:// \u6216 https\:// \u548c\u6709\u6548\u7684\u7db2\u57df\u540d\u7a31\u3002
 
-NewViewLink.NewView=\u65b0\u589e\u8996\u666f
-
 PatternProjectNamingStrategy.DisplayName=\u6a23\u5f0f
 PatternProjectNamingStrategy.NamePatternRequired=\u4e00\u5b9a\u8981\u8f38\u5165\u540d\u7a31\u6a23\u5f0f
 PatternProjectNamingStrategy.NamePatternInvalidSyntax=\u6b63\u898f\u8868\u793a\u5f0f\u8a9e\u6cd5\u932f\u8aa4\u3002

diff --git a/core/src/main/resources/lib/layout/tabNewItem.jelly b/core/src/main/resources/lib/layout/tabNewItem.jelly
@@ -10,7 +10,7 @@
     </st:documentation>
 
     <div class="tab">
-        <a href="${href}" class="addTab" aria-label="${attrs.title}">
+        <a href="${href}" class="addTab" aria-label="${attrs.title}" tooltip="${attrs.title}">
             <l:icon src="symbol-add" />
         </a>
     </div>

diff --git a/core/src/test/java/jenkins/model/NewViewLinkTest.java b/core/src/test/java/jenkins/model/NewViewLinkTest.java
diff --git a/test/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java b/test/src/test/java/jenkins/model/JenkinsLocationConfigurationTest.java
@@ -127,8 +127,9 @@ public void doNotAcceptNonHttpBasedRootURL_fromConfigXml() {
 
     @Test
     @Issue("SECURITY-1471")
-    public void cannotInjectJavaScriptUsingRootUrl_inNewViewLinkAction() throws Exception {
+    public void cannotInjectJavaScriptUsingRootUrl_inNewViewLink() throws Exception {
         JenkinsRule.WebClient wc = j.createWebClient();
+        j.createFreeStyleProject();
 
         settingRootURL("javascript:alert(123);//");