JENKINS-48716 Prevent Guava InvalidCacheLoadException

[gmshake]

Issue link JENKINS-48716

[coveralls]

Coverage remained the same at 49.661% when pulling 135687c on gmshake:JENKINS-48716 into 678f540 on jenkinsci:master.

[artkoshelev]

could you please provide test reproducing the problem?

[gmshake]

@artkoshelev Do you mean test steps or unit test? There're logs on our production instance like this, and I've made up local build environment and reproduced the problem.
Dec 25, 2017 5:45:29 PM WARNING hudson.model.listeners.RunListener report RunListener failed com.google.common.cache.CacheLoader$InvalidCacheLoadException: CacheLoader returned null for key PR-178. at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2383) at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2351) at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2313) at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2228) at com.google.common.cache.LocalCache.get(LocalCache.java:3965) at com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764) at hudson.plugins.jira.JiraSite.getIssue(JiraSite.java:467) at hudson.plugins.jira.JiraJobAction.setAction(JiraJobAction.java:99) at hudson.plugins.jira.JiraJobAction$RunListenerImpl.onStarted(JiraJobAction.java:130) at hudson.plugins.jira.JiraJobAction$RunListenerImpl.onStarted(JiraJobAction.java:122) at hudson.model.listeners.RunListener.fireStarted(RunListener.java:240) at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:254) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:421)

[artkoshelev]

@gmshake i mean unit or integration test, so we can validate that your change actually fixes problem and document this new behavior

[gmshake]

@artkoshelev Tests added.

[coveralls]

Coverage increased (+1.7%) to 51.406% when pulling d341a2e on gmshake:JENKINS-48716 into 678f540 on jenkinsci:master.

[rantoniuk]

Nice one! 🍺 for this one and for passing 50% coverage :-)

[gmshake]

@warden :)