Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to Jenkins 2.440.3 #612

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

sghill-rewrite
Copy link
Contributor

@sghill-rewrite sghill-rewrite commented Aug 12, 2024

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

I found a new SpotBugs rule started failing, so I added SuppressFBWarnings annotations to retain backwards compatibility. It would also be possible to make the public fields private, but I opted to suppress to avoid breaking changes.

Submitter checklist

Refs: sghill-rewrite/campaigns#4

Closes #610

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

@sghill-rewrite sghill-rewrite requested a review from a team as a code owner August 12, 2024 01:27
@rantoniuk rantoniuk merged commit 273cfb4 into jenkinsci:master Aug 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants