Add build selector parameter #1096
Conversation
There was a problem hiding this comment.
This is also supported by the Automatically Generated DSL:
buildSelectorParameter {
name(String value)
defaultSelector {
buildParameter {}
downstream {}
lastCompleted()
lastSuccessful {}
latestSavedBuild()
permalink {}
specific {}
upstream {}
workspace()
}
description(String value)
}
Either address the comments or close the PR if the generated DSL works for you.
| * @since 1.47 | ||
| */ | ||
| @PackageScope | ||
| Item getItem() { |
There was a problem hiding this comment.
It will return super.item. I wouldn't normally add it, but I have seen such method added in StepContext and thought you had some kind of convention in place for classes extending AbstractExtensibleContext. Should I just delete it?
| * | ||
| * @param classifier String value of the classifier | ||
| */ | ||
| void classifier(String classifier) { |
There was a problem hiding this comment.
make this a constructor parameter
| * @since 1.67 | ||
| */ | ||
| @RequiresPlugin(id = 'copyartifact', minimumVersion = '1.31') | ||
| void buildSelectorParameter(String parameterName, |
There was a problem hiding this comment.
Rename this to buildSelectorParam. All other methods in this context are named xxxParam, so we should keep the pattern.
|
@daspilker Thanks for the review. Must have missed notifications. Will address the comments today. |
|
@daspilker This auto-generated method does not work properly. I have enclosed info about that and error message in my first comment. |
OlgaMaciaszek
force-pushed
the
add-build-selector-parameter
branch
from
fce5219
to
f8ff09b
Compare
|
@daspilker I have added some changes. Please verify if this PR is ok now. |
|
@OlgaMaciaszek ah, I somehow missed the problem with the auto generated DSL. It happens when copyartifact and multijob plugins are installed. This seems to be a bug in multijob or structs plugin. I filed the problem as JENKINS-49963. Your PR looks good so far. Please add some tests to |
|
@daspilker I'm really sorry for not getting back to you earlier. I must have missed the notification. Will add the tests tomorrow. |
|
@daspilker I have added tests. Please have a look. |
| @@ -10,10 +10,13 @@ import javaposse.jobdsl.dsl.RequiresPlugin | |||
|
|
|||
| @ContextType('hudson.plugins.copyartifact.BuildSelector') | |||
| class CopyArtifactSelectorContext extends AbstractExtensibleContext { | |||
|
|
|||
| final String classifier | |||
|
@daspilker https://issues.jenkins-ci.org/browse/JENKINS-49963 has been closed automatically. Wouldn't it be good to re-open it? |
|
Hello @daspilker Is this PR fine now? Could it be merged? |
This is a PR to allow using the Build Selector Parameter for the Copy Artifact Plugin (https://wiki.jenkins.io/display/JENKINS/Copy+Artifact+Plugin),
NOTE: I do know that an auto-generated method for that in theory exists, however, it does not work properly. Using it according to the API causes the following error:
The changes in this PR have been tested and they generate the parameter correctly.