[JENKINS-36502] Fix Pipeline Snippet Generator #880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snippet generator has specific requirements for databound values. If there are databound setters without getters/public-fields, it throws and exeception to the log and generates only a class description for parameters. Fix for issue: https://issues.jenkins-ci.org/browse/JENKINS-36502
bitwiseman
force-pushed
the
JENKINS-36502
branch
from
fac6adc
to
c86395e
Compare
jglick
changed the title
| @@ -62,6 +62,7 @@ dependencies { | |||
| compile project(':job-dsl-core') | |||
| compile 'org.jenkins-ci:symbol-annotation:1.1' | |||
| jenkinsPlugins 'org.jenkins-ci.plugins:structs:1.2@jar' | |||
| jenkinsPlugins 'org.jenkins-ci.plugins.workflow:workflow-step-api:1.15@jar' | |||
|
I feel like there is something more deeply broken in the databinding in this plugin that the PR is just papering over. Why does it not just use standard patterns? |
|
Oh I see. Close this. The problem is |
|
e.g. use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daspilker
The snippet generator is apparently rather picky about databound values.
If there are databound setters without getters/public-fields, it just returns a class description.
Fix for issue: https://issues.jenkins-ci.org/browse/JENKINS-36502