Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-30040] Logging exception running triggering nonblocking builds #92

Merged
merged 2 commits into from Sep 10, 2015

Conversation

@svanoort
Copy link
Member

commented Sep 1, 2015

Builds on top of fix in PR #90 but includes tests. I've manually verified this works correctly from the UI as well.

@tonyfinn @reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

commented Sep 1, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -157,10 +158,12 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher,
return buildStepResult;
}

private String getProjectListAsString(List<Job> projectList){
// Public but restricted so we can add tests without completely changing the tests package
@Restricted(value=org.kohsuke.accmod.restrictions.NoExternalUse.class)

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Sep 1, 2015

Member

NIT: would be better to just import the class, value= is also not required

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

🐝

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@tfennelly

This comment has been minimized.

Copy link
Member

commented Sep 2, 2015

🐝

@svanoort

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2015

@svanoort

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2015

@ikedam Any thoughts on this, as maintainer?

@ikedam

This comment has been minimized.

Copy link
Member

commented Sep 8, 2015

@svanoort
I no longer maintain this plugin.
Please contact the current maintainer.

@svanoort

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2015

Thanks!

@olivergondza Would you have any issues if this were merged / released? It's a fairly trivial fix for an irritating bug.

@olivergondza olivergondza merged commit bbccd61 into master Sep 10, 2015

1 check passed

Jenkins This pull request looks good
Details
olivergondza added a commit that referenced this pull request Sep 10, 2015
Merge pull request #92 from jenkinsci/JENKINS-30040-tests
[JENKINS-30040] Logging exception running triggering nonblocking builds
@olivergondza

This comment has been minimized.

Copy link
Member

commented Sep 10, 2015

Releasing 2.29 right now.

@svanoort svanoort deleted the JENKINS-30040-tests branch Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.