[JENKINS-30040] Logging exception running triggering nonblocking builds #92
Conversation
…igger-plugin into JENKINS-30040-tests
…king build step trigger
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -157,10 +158,12 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, | |||
| return buildStepResult; | |||
| } | |||
|
|
|||
| private String getProjectListAsString(List<Job> projectList){ | |||
| // Public but restricted so we can add tests without completely changing the tests package | |||
| @Restricted(value=org.kohsuke.accmod.restrictions.NoExternalUse.class) | |||
There was a problem hiding this comment.
NIT: would be better to just import the class, value= is also not required
|
🐝 |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
🐝 |
|
@reviewbybees done. |
|
@ikedam Any thoughts on this, as maintainer? |
|
@svanoort |
|
Thanks! @olivergondza Would you have any issues if this were merged / released? It's a fairly trivial fix for an irritating bug. |
[JENKINS-30040] Logging exception running triggering nonblocking builds
|
Releasing 2.29 right now. |
Builds on top of fix in PR #90 but includes tests. I've manually verified this works correctly from the UI as well.
@tonyfinn @reviewbybees