Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PCT failures past 2.281 #419

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Fix PCT failures past 2.281 #419

merged 2 commits into from
Jun 3, 2021

Conversation

res0nance
Copy link
Contributor

bitwiseman
bitwiseman requested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one question.

...st/java/org/jenkinsci/plugins/pipeline/modeldefinition/generator/DirectiveGeneratorTest.java Outdated
@@ -150,12 +152,12 @@ public void simpleInput() throws Exception {

// TODO: Remove once we move to a baseline of 2.90 or later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@res0nance
We've moved to a baseline way past 2.90. Should this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me reword it

@jetersen
Copy link
Member

Seems the build failure is related to infra issues, if someone could trigger the build that would be nice :)

@jetersen
Copy link
Member

Another infra issue it seems:

hudson.plugins.git.GitException: Command "git.exe fetch --tags --force --progress -- C:\Users\jenkins\Work\workspace\e-model-definition-plugin_PR-419\pipeline-model-definition\target\tmp\junit3356454706115552377\junit5235385210740340602 +refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: error: git upload-pack: git-pack-objects died with error.
fatal: git upload-pack: aborting due to possible repository corruption on the remote side.
remote: aborting due to possible repository corruption on the remote side.�
fatal: protocol error: bad pack header

@jetersen
Copy link
Member

jetersen commented Jun 2, 2021

Poke: This passes.
A release would be nice :)

@jglick
Copy link
Member

jglick commented Jun 3, 2021

@bitwiseman ping

@bitwiseman bitwiseman merged commit 86240ce into jenkinsci:master Jun 3, 2021
@res0nance res0nance deleted the pct branch June 4, 2021 06:20
@timja
Copy link
Member

timja commented Jun 4, 2021

@bitwiseman @car-roll @dwnusbaum can we get a release please?

@bitwiseman
Copy link
Contributor

Will do.

@saper
Copy link

saper commented Jun 7, 2021

Hello, I came here from the release notes - what exactly is PCT?

@timja
Copy link
Member

timja commented Jun 7, 2021

A tool for testing plugin compatibility against other plugins and newer Jenkins core version, a compatibility break in tests was picked up from a Jenkins core change which required test fixes here.

https://github.com/jenkinsci/plugin-compat-tester

@jetersen
Copy link
Member

jetersen commented Jun 7, 2021

A search on jenkins-ci org reveals this: https://github.com/search?q=org%3Ajenkinsci+pct&type=source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@res0nance @jetersen @jglick @timja @bitwiseman @saper