Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize new LTS line (2.289) #511

Merged
merged 10 commits into from
Jun 5, 2021
Merged

Initialize new LTS line (2.289) #511

merged 10 commits into from
Jun 5, 2021

Conversation

res0nance
Copy link
Contributor

@res0nance res0nance commented May 8, 2021

Prep work for jenkins-infra/release#153

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fixes #491

@timja timja added the enhancement New feature or request label May 8, 2021
@jglick
Copy link
Member

jglick commented May 8, 2021

see #491

@res0nance
Copy link
Contributor Author

Remaining seems to be issues with pipeline-input-step for some reason the automated test breaks not exactly sure why. Manually testing it proves it still works. But due to the same reason a good chunk of pipeline-model-definition tests fail because they use input. pipeline-model-definition also has some parameter tests that need simple fixes as well. Outside of that we have ssh-slaves I haven't taken a close look at that one.

@res0nance
Copy link
Contributor Author

So the issue to ssh-slaves seems related to pipeline-input step where clicking an element seems to not pass its parameters as well. It only affects 2.289 not 2.288. Might be related to jenkinsci/jenkins#5405

@res0nance
Copy link
Contributor Author

James has filed https://issues.jenkins.io/browse/JENKINS-65585, which is likely related to some of these failures

@jglick
Copy link
Member

jglick commented May 10, 2021

Feel free to add exclusions to pct.sh for cases where you have already filed PRs to correct the situation.

@jtnord
Copy link
Member

jtnord commented May 11, 2021

see also jenkinsci/jenkins#5481

@jetersen
Copy link
Member

Seems we are down to pct-pipeline-model-definition-2.289.x failure

@jglick
Copy link
Member

jglick commented Jun 3, 2021

Make sure to merge in master.

@jglick
Copy link
Member

jglick commented Jun 4, 2021

Blocking #538 (thus picking up jenkinsci/ssh-credentials-plugin#70). #536 thus jenkinsci/credentials-plugin#205 is already in so may as well go ahead with #533 thus jenkinsci/credentials-binding-plugin#132.

@res0nance
Copy link
Contributor Author

This is finally passing if anyone can merge it

@jetersen jetersen merged commit d6e713d into jenkinsci:master Jun 5, 2021
@jetersen
Copy link
Member

jetersen commented Jun 5, 2021

This is finally passing if anyone can merge it

Done 😃

@res0nance res0nance deleted the LTS-2.289 branch June 5, 2021 05:10
@jglick jglick mentioned this pull request Jun 5, 2021
@@ -1 +1 @@
true
false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.289.x
5 participants