Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-33256] Calling SCMSource.getTrustedRevision #244

Merged
merged 4 commits into from Mar 11, 2016

Conversation

@jglick
Copy link
Member

jglick commented Nov 6, 2015

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Nov 6, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@stephenc

This comment has been minimized.

Copy link
Member

stephenc commented Nov 6, 2015

🐝

1 similar comment
@recena

This comment has been minimized.

Copy link
Contributor

recena commented Nov 15, 2015

🐝

@KostyaSha

This comment has been minimized.

Copy link
Member

KostyaSha commented Jan 7, 2016

Status?

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Jan 7, 2016

I ran out of time to try using the new API and confirm that it solves the problem. On my list.

@KostyaSha

This comment has been minimized.

Copy link
Member

KostyaSha commented Jan 7, 2016

@jglick i see no examples or description of supporting multibranches

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Jan 7, 2016

Because the proposed usage is in a plugin which is currently not OSS.

@jglick jglick changed the title Calling SCMSource.getTrustedRevision [JENKINS-33256] Calling SCMSource.getTrustedRevision Mar 2, 2016
@jglick jglick mentioned this pull request Mar 7, 2016
5 of 5 tasks complete
@kzantow

This comment has been minimized.

Copy link
Contributor

kzantow commented Mar 10, 2016

🐝

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Mar 10, 2016

@reviewbybees done

(but pointless to merge unless and until jenkinsci/github-branch-source-plugin#29 is)

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Mar 10, 2016

Actually I take that back—Pipeline has a more heavyweight release process so there might be a timing advantage in having this released earlier. Also I know of at least one other SCMSource which might be able to take advantage of this (@amuniz). The patch should be safe enough since getTrustedRevision defaults to just returning its argument, so the worst that can happen is that the API turns out to be not as useful as originally thought and must be deprecated.

An scm-api 1.1 release is a prerequisite, though.

jglick added a commit that referenced this pull request Mar 11, 2016
[JENKINS-33256] Calling SCMSource.getTrustedRevision
@jglick jglick merged commit 76bdc6f into jenkinsci:master Mar 11, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
@jglick jglick deleted the jglick:getTrustedRevision branch Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.