Fixing an incorrect pattern match target (in name/label replacement in the URL) #8
Conversation
The code as before would look for "%name%" in the label (which is the CSV column header) and replace it with the label again, and then make that the URL. This makes no sense. This change makes the code work with what I believe the intention of the pattern matching was.
|
plugins » plot-plugin #3 UNSTABLE |
|
This is missing test coverage (it seems a lot of things are). The test that is failing supplies a null URL. I'm not a Java developer and I have no environment to test this on, so I have to leave it to the community to resolve the tests. |
|
pjquirk, I will check that. Thank you for reporting! If you want, you can also open an issue at https://issues.jenkins-ci.org/browse/JENKINS/component/15564 |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Would be really nice to see this bug fixed! Can someone complete this pull request? Not a Java developer myself. |
|
I forgot to mention the original question from Stack Overflow |
Fixing an incorrect pattern match target (in name/label replacement in the URL)
|
@JeroenVdb, I hope to release a new version by the weekend. |
The code as before would look for "%name%" in the label (which is the
CSV column header) and replace it with the label again, and then make
that the URL. This makes no sense.
This change makes the code work with what I believe the intention of the
pattern matching was.