Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-200] Oops #42

Merged
merged 1 commit into from
Jan 12, 2018
Merged

[JEP-200] Oops #42

merged 1 commit into from
Jan 12, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 11, 2018

Mistake in #4 caught by jenkinsci/jenkins#3120.

@reviewbybees esp. @oleg-nenashev

@ghost
Copy link

ghost commented Jan 11, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 for sure, now I need to understand whether is was covered by tests

@oleg-nenashev
Copy link
Member

It won't make the things worse, I'd guess

@oleg-nenashev oleg-nenashev merged commit e1add4b into jenkinsci:master Jan 12, 2018
@jglick jglick deleted the JEP-200 branch January 12, 2018 17:04
@oleg-nenashev
Copy link
Member

tested the plugin manually. It works fine, including the upgrade scenarion. Attempted to upgrade POM/core in #43 , but it will take a while. Releasing as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants