Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jacoco to 0.7.9 and move it to the profile #207

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

oleg-nenashev
Copy link
Member

Jacoc agent is quite heavy, and I see no reason in running it by default in any Remoting build.
This change moves the agent to an optional profile. It also picks the latest version, so IntellijIDEA is now able to read and show the jacoco.exe report.

@reviewbybees

Jacoc agent is quite heavy, and I see no reason in running it by default in any Remoting build.
This change moves the agent to an optional profile. It also picks the latest version, so IntellijIDEA is now able to read and show the `jacoco.exe` report
@oleg-nenashev
Copy link
Member Author

Actually it picks some bits of #194 (though the PR does not seem to be required anymore)

@ghost
Copy link

ghost commented Oct 30, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev
Copy link
Member Author

[INFO] --- maven-jar-plugin:3.0.2:jar (default-jar) @ remoting ---
[INFO] Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-archiver/3.1.1/maven-archiver-3.1.1.pom
Oct 30, 2017 2:07:08 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection timed out (Read failed)
Oct 30, 2017 2:07:08 PM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443

Copy link
Member

@recampbell recampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-nenashev
Copy link
Member Author

@reviewbybees done

@oleg-nenashev
Copy link
Member Author

I am going to ignore the CI issue. The PR builder still needs to be fixed

@oleg-nenashev oleg-nenashev merged commit bb1ceee into jenkinsci:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants