Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Replace Integration Tests with Unit Tests #35

Closed
h1dden-da3m0n opened this issue Dec 8, 2020 · 1 comment
Closed

[FEATURE] Replace Integration Tests with Unit Tests #35

h1dden-da3m0n opened this issue Dec 8, 2020 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@h1dden-da3m0n
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Since 5b60dad failed the integration-tests due to using dynamic data (whatever I was thinking creating them this way 🤦‍♂️) I had to push ac77a7a just to make the tests pass again.

Describe the solution you'd like

Replace the iteration-tests with proper unit-tests.

Describe alternatives you've considered

remove the offending tests, yet that is not a solution -.-

Additional context

N/A
@h1dden-da3m0n h1dden-da3m0n added the enhancement New feature or request label Dec 8, 2020
@h1dden-da3m0n h1dden-da3m0n added the wontfix This will not be worked on label May 31, 2022
@h1dden-da3m0n
Copy link
Contributor Author

Replacing these test is unlikely going to happen and even if it where, a healthy dose of integration tests accompanying your unit tests is always preferable than having just one or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h1dden-da3m0n