JENKINS-27284: Constrain build result severity #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a per-job setting to constrain the build result nastiness set by the plugin for problems that occur inside the plugin. That is, an S3 failure that would normally result in a FAILURE can be constrained to UNSTABLE or SUCCESS. This addresses JENKINS-27284 <https://issues.jenkins-ci.org/browse/JENKINS-27284> by providing a way to prevent S3 plugin failures from causing an otherwise successful build to be marked as having failed.
|
This supersedes #53 |
Jimilian
reviewed
Nov 15, 2016
| @@ -69,6 +70,7 @@ public S3BucketPublisher(String profileName, List<Entry> entries, List<MetadataP | |||
|
|
|||
| this.dontWaitForConcurrentBuildCompletion = dontWaitForConcurrentBuildCompletion; | |||
| this.consoleLogLevel = parseLevel(consoleLogLevel); | |||
| this.pluginFailureResultConstraint = Result.fromString(pluginFailureResultConstraint); | |||
There was a problem hiding this comment.
If I remember correctly, default value for pluginFailureResultConstraint would be null (for users who just updated plugin). Please, adjust default value to keep backward compatibility.
There was a problem hiding this comment.
@Jimilian How this latest commit?
Jimilian
reviewed
Nov 16, 2016
| @@ -236,9 +259,9 @@ public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath ws, @Nonnull Launc | |||
| run.addAction(new S3ArtifactsAction(run, profile, artifacts)); | |||
| run.addAction(new FingerprintAction(run, record)); | |||
| } | |||
| } catch (IOException e) { | |||
| } catch (Exception e) { // Any failure in this plugin should be constrained according to config | |||
There was a problem hiding this comment.
Why do you need to suppress InterruptedException? It could break a lot of stuff. Because it would continue execution then it's not desired.
If build was interrupted by Jenkins (i.e. aborted from timeout plugin, executor was stopped from UI, etc.), it doesn't have chance to pass (at least I can't imagine such case).
|
Great. Thanks you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a per-job setting to constrain the build result
nastiness set by the plugin for problems that occur inside the plugin.
That is, an S3 failure that would normally result in a FAILURE can
be constrained to UNSTABLE or SUCCESS.
This addresses JENKINS-27284
https://issues.jenkins-ci.org/browse/JENKINS-27284 by providing a
way to prevent S3 plugin failures from causing an otherwise successful
build to be marked as having failed.