Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-47876] fix url of jobs in subfolder of views #299

Merged
merged 1 commit into from
Feb 10, 2024
Merged

[JENKINS-47876] fix url of jobs in subfolder of views #299

merged 1 commit into from
Feb 10, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Feb 2, 2024 •
edited by MarkEWaite
Loading

JENKINS-47876 - fix url of jobs in subfolder of views

when a view includes jobs from subfolder the url is not properly calculated.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply, remove the rows that do not apply.

  • Bug fix (non-breaking change which fixes an issue)

@mawinter69 mawinter69 requested a review from a team as a code owner February 2, 2024 22:53
@mawinter69
[JENKINS-47876] fix url of jobs in subfolder of views
b96ac74 
when a view includes jobs from subfolder the url is not properly
calculated.
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Feb 6, 2024
MarkEWaite
MarkEWaite approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with interactive testing that I can see the failure before this change and that the failure no longer happens after this change. Thanks!

@MarkEWaite MarkEWaite merged commit 8ebe2fc into jenkinsci:master Feb 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug Incorrect or flawed behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mawinter69 @MarkEWaite