-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-33808] New API for support Item Categorization #9
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
@@ -40,6 +40,12 @@ protected SCMNavigatorDescriptor(Class<? extends SCMNavigator> clazz) { | |||
super(clazz); | |||
} | |||
|
|||
public abstract String getDescription(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 missing Javadoc (3×).
🐛 define a default |
* @since TODO | ||
*/ | ||
@Nonnull | ||
public abstract String getDescription(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 incompatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -41,6 +42,46 @@ protected SCMNavigatorDescriptor(Class<? extends SCMNavigator> clazz) { | |||
} | |||
|
|||
/** | |||
* A description of this kind of {@link SCMNavigator}. This description can contain HTML code but it is recommend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommended
@jglick Do you agree with the changes? |
@@ -41,9 +42,51 @@ protected SCMNavigatorDescriptor(Class<? extends SCMNavigator> clazz) { | |||
} | |||
|
|||
/** | |||
* A description of this kind of {@link SCMNavigator}. This description can contain HTML code but it is recommended | |||
* to use text plain in order to avoid how it should be represented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐜 Javadoc link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(resolved)
🐝 |
🐝 |
JENKINS-33808
@reviewbybees