Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-33808] New API for support Item Categorization #9

Merged
merged 13 commits into from
Apr 11, 2016

Conversation

recena
Copy link
Collaborator

@recena recena commented Apr 5, 2016

JENKINS-33808

@reviewbybees

@ghost
Copy link

ghost commented Apr 5, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@@ -40,6 +40,12 @@ protected SCMNavigatorDescriptor(Class<? extends SCMNavigator> clazz) {
super(clazz);
}

public abstract String getDescription();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 missing Javadoc (3×).

@jglick
Copy link
Member

jglick commented Apr 5, 2016

🐛 define a default newInstanceDetail.jelly

@recena
Copy link
Collaborator Author

recena commented Apr 5, 2016

@jglick some comments were addressed here

* @since TODO
*/
@Nonnull
public abstract String getDescription();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 incompatible

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick After this commit I have to work on this method.

@@ -41,6 +42,46 @@ protected SCMNavigatorDescriptor(Class<? extends SCMNavigator> clazz) {
}

/**
* A description of this kind of {@link SCMNavigator}. This description can contain HTML code but it is recommend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommended

@recena
Copy link
Collaborator Author

recena commented Apr 11, 2016

@jglick Do you agree with the changes?

@@ -41,9 +42,51 @@ protected SCMNavigatorDescriptor(Class<? extends SCMNavigator> clazz) {
}

/**
* A description of this kind of {@link SCMNavigator}. This description can contain HTML code but it is recommended
* to use text plain in order to avoid how it should be represented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐜 Javadoc link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(resolved)

@jglick
Copy link
Member

jglick commented Apr 11, 2016

🐝

@jglick
Copy link
Member

jglick commented Apr 11, 2016

🐝

@stephenc stephenc merged commit 410e106 into jenkinsci:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants