Send more advanced slack messages v2

[gurumaia]

Based on @ahmetrehaseker's implementation.
This is a change to support slack complex messaging.
See #285 for more details.

[rafi-tvtime]

looks good to me. let's do this!

[gurumaia]

Can someone review this?

[samrocketman]

Hey @gurumaia, I'll take a look as well and try bootstrapping it with https://github.com/samrocketman/jenkins-bootstrap-slack. Please also refer to #320 as I generally am attempting to distance myself from this plugin specifically.

[ejohansson]

Looks good, no apparent issues.

[ejohansson]

Doc looks good to me, test looks good.

[gurumaia]

Alright, great @samrocketman. I did see your commits about removing yourself as a maintainer. I can try to step up and help maintain the plugin if you'd like.

[samrocketman]

@gurumaia you're welcome to step up and maintain. Feel free to check in with @kmadel who, as far as I know, has not relinquished being the other maintainer. I'm sure he wouldn't mind bringing you on board. Feel free to send a message to the developers mailing list, mention Kurt, and this discussion.

[djk]

Would be amazing to have this reviewed and hopefully approved. Is @gurumaia taking it over?

[gurumaia]

Hey @djk I'll contact @kmadel to see if I can get in. This has been on the back of my mind lately as I've had quite a few rushed days these past few weeks.
Btw, the plugin has been working nicely in my production environment. While this isn't approved, feel free to clone my repo and build using the instructions in the readme.

[djk]

Thanks @gurumaia, I'll check your repo!

Wasn't hassling you, hope it doesn't feel that way. Thanks for the great work.

[gurumaia]

Absolutely no hassling =).

btw, I didn't actually code this, I just took @ahmetrehaseker's old PR and performed @samrocketman's suggestions.

[djk]

@gurumaia

Ah right, well thanks to @ahmetrehaseker and @samrocketman too!

One thing, not sure where best to mention this but does your PR support "fields": https://api.slack.com/docs/message-attachments#fields

I'm not quite sure how one would enter a JSON array into the example that you provided on the page of your fork.

EDIT: Got it to work with help of a friend, like:

      JSONObject fieldOne = new JSONObject();
        fieldOne.put('title', 'Build');
        fieldOne.put('value', "<${env.BUILD_URL}|${env.BUILD_NUMBER}>");
        fieldOne.put('short', true);
        fields.add(fieldOne);

And repeating for more fields etc.

EDIT: The above doesn't seem to work in regard to actually doing the interpolation of variables. Is there some escaping required?

Thanks again!

[gurumaia]

@djk sorry, I missed your edit.
The code you posted seems like it should work fine. What value are you getting in slack?
For reference, here's an example from one of my internal projects:

        String artifactUrl = "${env.NEXUS_URL_NOTIFY}${env.pom_groupId}/${env.pom_artifactId}/${env.pom_new_version}/${env.pom_artifactId}-${env.pom_new_version}.${env.pom_packaging}"

        JSONArray fields = new JSONArray();
        JSONObject field = new JSONObject();
        field.put('title','URL Nexus');
        field.put('value',artifactUrl);
        fields.add(field);
        attachment.put('fields',fields);

@kmadel If you could review this PR, I can go ahead and merge it.
Thanks

[kmadel]

Decent doc update, it has tests, looks ok to me. I so go for it @gurumaia and thanks.

[DaBs]

Looks good, has tests, new features are much needed in a lot of cases.

[rafi-tvtime]

Is this being merged?

[brianespinosa]

+1 for this feature getting merged now that it appears to have tests and looks good.

[gurumaia]

I've merged and now I'm waiting for approval on my request for upload access to actually release it: jenkins-infra/repository-permissions-updater#399

[brianespinosa]

@gurumaia Any idea on timing to release this? I noticed that your above referenced PR giving you access has been merged. Thanks again for your help taking this over.

[gurumaia]

Hey @brianespinosa I've finally released it to the update center yesterday. Should be available now. Please test it and let me know if it works well for you.

[ghost]

Doesn't this revert the fix in 3905e00#diff-282db0eb13a24d1729df3e194a35f6d7 #274 made by @p00j4 ?
So that messages over 4K will be truncated again. Because that is at least what I am seeing in version 2.3.