Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-40001] Add plugin description to POM. #36

Merged
merged 5 commits into from Jan 13, 2017

Conversation

varyvol
Copy link

@varyvol varyvol commented Nov 24, 2016

JENKINS-40001

@reviewbybees, specially @stephenc @olamy @kohsuke

@ghost
Copy link

ghost commented Nov 24, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -13,6 +13,7 @@

<name>Jenkins SSH Slaves plugin</name>
<url>http://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url>
<description>Allows to manage slaves running on Unix machines over SSH</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't call them slaves any more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also differs slightly from the existing description in readme.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the text to use launch instead of manage and also agents instead of slaves.

@@ -13,6 +13,7 @@

<name>Jenkins SSH Slaves plugin</name>
<url>http://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this PR, I'd change http to https

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add src/main/resources/index.jelly.

@varyvol
Copy link
Author

varyvol commented Dec 12, 2016

@recena @jglick done.

@recena
Copy link
Contributor

recena commented Dec 12, 2016

🐝

@varyvol
Copy link
Author

varyvol commented Dec 20, 2016

@jglick @stephenc could you please review this?

Copy link
Member

@stephenc stephenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clarify that this uses a Java implementation of SSH not the native code implementation of SSH

@@ -12,7 +12,8 @@
<packaging>hpi</packaging>

<name>Jenkins SSH Slaves plugin</name>
<url>http://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url>
<url>https://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url>
<description>Allows to launch agents running on Unix machines over SSH</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

append using a Java implementation of the SSH protocol

@@ -0,0 +1,4 @@
<?jelly escape-by-default='true'?>
<div>
Allows to launch agents running on Unix machines over SSH.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto for change in pom

@varyvol
Copy link
Author

varyvol commented Jan 3, 2017

@stephenc changes done.

@varyvol
Copy link
Author

varyvol commented Jan 13, 2017

@reviewbybees done.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@recena recena merged commit 1df5326 into jenkinsci:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants