New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-40001] Add plugin description to POM. #36
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
@@ -13,6 +13,7 @@ | |||
|
|||
<name>Jenkins SSH Slaves plugin</name> | |||
<url>http://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url> | |||
<description>Allows to manage slaves running on Unix machines over SSH</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't call them slaves any more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also differs slightly from the existing description in readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the text to use launch instead of manage and also agents instead of slaves.
@@ -13,6 +13,7 @@ | |||
|
|||
<name>Jenkins SSH Slaves plugin</name> | |||
<url>http://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this PR, I'd change http
to https
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add src/main/resources/index.jelly
.
🐝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to clarify that this uses a Java implementation of SSH not the native code implementation of SSH
@@ -12,7 +12,8 @@ | |||
<packaging>hpi</packaging> | |||
|
|||
<name>Jenkins SSH Slaves plugin</name> | |||
<url>http://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url> | |||
<url>https://wiki.jenkins-ci.org/display/JENKINS/SSH+Slaves+plugin</url> | |||
<description>Allows to launch agents running on Unix machines over SSH</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
append using a Java implementation of the SSH protocol
@@ -0,0 +1,4 @@ | |||
<?jelly escape-by-default='true'?> | |||
<div> | |||
Allows to launch agents running on Unix machines over SSH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto for change in pom
@stephenc changes done. |
@reviewbybees done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
JENKINS-40001
@reviewbybees, specially @stephenc @olamy @kohsuke