-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use secretTextarea for SSH key UI #40
Conversation
Does this mean that I will no longer be able to copy the private key from the credential editing page? I've liked that a lot in the past to confirm the private key text is correct and complete. |
Just "replace" it with the one you know is correct? |
Right, that does mean that. I wonder if adding a sort of fingerprint to the UI would be nice. |
Yes, that's what it means. From the user perspective, the key becomes kind of write-only. It is easier to be able to view the key, as it has been, but it's not very good security practice. See for example how GitHub or AWS handles keys like this. Unfortunately security can be inversely proportional to productivity, as it kind of is in this case. |
That would be a nice follow-up enhancement. I like how some other systems do that. |
The fingerprinting especially makes sense if the underlying secret is a crypto key that has a well-defined fingerprint. Otherwise, we could provide something like a SHA-256 hash of the data or something. |
Understood that it is poor security practice to show me the contents of the private key. Thanks for the clarification. If in some future version you decide to display something like a checksum, it might be nice to consider showing the "asciiart" which is displayed by the command
|
Ooh, that'd be a cool idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐝
Perhaps seems interesting to describe the problem + create ticket?
Created https://issues.jenkins-ci.org/browse/JENKINS-56940 for the UI improvement. |
src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/BasicSSHUserPrivateKey.java
Show resolved
Hide resolved
Signed-off-by: Matt Sicker <boards@gmail.com>
Signed-off-by: Matt Sicker <boards@gmail.com>
Signed-off-by: Matt Sicker <boards@gmail.com>
Some sort of |
Using the backport from jenkinsci/jenkins#3967
This replaces the textarea form input for SSH keys with a new custom editor for multiline secrets. See the above PR for screenshots.