Add f:secretTextarea UI analogous to f:password #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as f:password is provided for secrets instead of f:textinput, this f:secretTextarea is provided for secrets instead of f:textarea where said secrets are multiline in nature. While this component does not provide any way to view an existing secret, it provides UIs to add and replace secrets. Signed-off-by: Matt Sicker <boards@gmail.com>
|
Good to add to the changelog entry the name of the new tag, easy to find when searching in the changelog |
|
The code is good. I'm just not sure it's a good idea to duplicate it into both a library and core. |
Wadeck
approved these changes
Apr 5, 2019
| replaceUpdateButton(); | ||
| removeSecretLegendLabel(); | ||
| // fix UI bug when DOM changes | ||
| Event.fire(window, 'jenkins:bottom-sticker-adjust'); |
daniel-beck
approved these changes
Apr 5, 2019
batmat
approved these changes
Apr 5, 2019
There was a problem hiding this comment.
Looks good to me.
I guess it'd be good to also add an example usage in https://github.com/jenkinsci/ui-samples-plugin?
batmat
added
the
ready-for-merge
|
This is ready for merge. Given the small scope of this, fully new and unused yet I suppose, this is not very risky. Let's give it slightly more time, and merge it later today or tomorrow, so it goes in the next weekly. Please anyone object before we proceed, if there's any issue with this. Thanks everyone. |
Introduces new API to be supported forever though 🤷♂️ |
This was referenced Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as f:password is provided for secrets instead of f:textinput,
this f:secretTextarea is provided for secrets instead of f:textarea
where said secrets are multiline in nature. While this component does
not provide any way to view an existing secret, it provides UIs to
add and replace secrets.
Code ported from standalone library: https://github.com/jenkinsci/lib-multiline-secrets-ui
Screenshots:
See JENKINS-TODO.
Proposed changelog entries
f:secretTextareato/lib/formfor adding and replacing multi-line secrets analogous to passwords for single-line.Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@reviewbybees @jeffret-b @daniel-beck @batmat @Wadeck @thoulen