Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-44860] BasicSSHUserPrivateKey.usernameSecret #70

Merged
merged 9 commits into from
Jun 2, 2021
Merged

[JENKINS-44860] BasicSSHUserPrivateKey.usernameSecret #70

merged 9 commits into from
Jun 2, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented May 6, 2021

@jglick jglick mentioned this pull request May 6, 2021
Merged
@jglick jglick mentioned this pull request Jun 2, 2021
Merged
bitwiseman
bitwiseman approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than talking about the history, the help should describe the current functioning. Other than that LGTM.

@jglick jglick merged commit 3d7e980 into jenkinsci:master Jun 2, 2021
@jglick jglick deleted the show-username-JENKINS-44860 branch June 2, 2021 23:03
@jglick jglick mentioned this pull request Jun 4, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

@car-roll car-roll car-roll approved these changes

@daniel-beck daniel-beck Awaiting requested review from daniel-beck

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@jglick @bitwiseman @car-roll