[JENKINS-48924, JENKINS-48995] - Fix plugin compatibility with Jenkins 2.102+ #29

oleg-nenashev · 2018-01-16T17:12:21Z

TestLinkBuildAction and TestLinkResult do not longer serialize build instance
Whitelist TestLink API model classes, which are being persisted in reports
Fix the Builder in ResultTestCaseSeeker class

https://issues.jenkins-ci.org/browse/JENKINS-48924
https://issues.jenkins-ci.org/browse/JENKINS-48995

@reviewbybees @jglick

…estCaseWrapper

oleg-nenashev · 2018-01-16T17:13:32Z

src/main/java/hudson/plugins/testlink/TestLinkBuildAction.java

 import org.kohsuke.stapler.StaplerProxy;

 /**
 * @author Bruno P. Kinoshita - http://www.kinoshita.eti.br
 * @since 1.0
 */
-public class TestLinkBuildAction implements Action, Serializable, StaplerProxy {
+public class TestLinkBuildAction implements RunAction2, Serializable, StaplerProxy {


Surprisingly, #25 does not do that

ghost · 2018-01-16T17:15:35Z

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

oleg-nenashev · 2018-01-16T17:23:52Z

I currently cannot say whether it work on agents actually, the autotests do not seem to cover that

oleg-nenashev · 2018-01-16T17:47:24Z

PCT passes with this fix BTW

jglick · 2018-01-16T23:01:37Z

src/main/java/hudson/plugins/testlink/TestLinkBuildAction.java


    private static final long serialVersionUID = -914904584770393909L;

    public static final String DISPLAY_NAME = "TestLink";
    public static final String ICON_FILE_NAME = "/plugin/testlink/icons/testlink-24.png";
    public static final String URL_NAME = "testLinkResult";

-    private AbstractBuild<?, ?> build;
+    private transient Run<?, ?> build;


Good, making this transient should solve a host of issues.

oleg-nenashev · 2018-01-17T15:54:34Z

Also fixed TestNG logic, which serialization has not been covered by tests
@jglick @kinow PTAL

oleg-nenashev · 2018-01-17T15:55:15Z

src/main/java/hudson/plugins/testlink/result/AbstractTestNGResultSeeker.java

@@ -58,7 +57,7 @@

 	public static final String TEXT_XML_CONTENT_TYPE = "text/xml";

-	protected final TestNGParser parser = new TestNGParser();
+	protected transient TestNGParser _parser = null;


The class could be actually made static, but it needs update of the bundled lib

Maybe should be volatile.

Does not matter much. In the worst case there will be two instances of a same class which actually has no dynamic context at all. The class methods should be reworked to static, I just decided not to do breaking changes in this PR

jglick · 2018-01-19T18:46:56Z

src/test/java/hudson/plugins/testlink/result/ResultSeekerTest.java

+import javax.management.Descriptor;
+
+@For(ResultSeeker.class)
+@Ignore


specify a reason in the annotation value

Oops, I pushed an unfinished test.
It does not hurt in the current state, but I will remove the file

jglick · 2018-01-19T18:47:14Z

src/main/java/hudson/plugins/testlink/result/AbstractTestNGResultSeeker.java

@@ -58,7 +57,7 @@

 	public static final String TEXT_XML_CONTENT_TYPE = "text/xml";

-	protected final TestNGParser parser = new TestNGParser();
+	protected transient TestNGParser _parser = null;


Maybe should be volatile.

…current state

oleg-nenashev · 2018-01-24T09:49:35Z

@kinow I noticed the plugin is up for adoption. Do you have time to review/release it or should we proceed on our own?

kinow · 2018-01-24T20:31:57Z

@oleg-nenashev either way works for me. I stopped keeping up to date with Jenkins plugin/core API when the workflow-plugin was still in the works, and haven't had time to catch up with the changes.

Looks to me like most of the changes are for the JEP and Jenkins/plug-in API. No changes in the way the plug-in interacts with TestLink or test reports. So everything should work the same for users (just much better, and in the latest versions of Jenkins :-) ).

So +1, LGTM, and thanks a lot!

Happy to merge it, or feel free to merge it. Do we need #25 merged as well?

If you'd like to take over the plug-in, I'd be OK with that too :) tho I suspect you are probably busy with other things and just needs to fix this issue and have a new release out?

Ta
B

ghost · 2018-01-24T22:26:02Z

Yes, I definitely have no capacity to maintain new plugins, sorry. Was about marking about 15 of my plugins for adoption. If you could just spin a release, it would be great.

…

On Jan 24, 2018 21:32, "Bruno P. Kinoshita" ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKBqVHABcBoAx5g7utebHc74MrqNzzO5ks5tN5NLgaJpZM4RgHiS> . -- You received this message because you are subscribed to the Google Groups "engineering-code-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to ***@***.*** To post to this group, send email to engineering-code-reviews@ cloudbees.com. To view this discussion on the web visit https://groups.google.com/a/ cloudbees.com/d/msgid/engineering-code-reviews/jenkinsci/testlink-plugin/ pull/29/review/91320432%40github.com <https://groups.google.com/a/cloudbees.com/d/msgid/engineering-code-reviews/jenkinsci/testlink-plugin/pull/29/review/91320432%40github.com?utm_medium=email&utm_source=footer> .

oleg-nenashev · 2018-01-24T22:34:29Z

Sorry, responded from wrong email On Jan 24, 2018 23:26, "Code Reviewed by CloudBees" < notifications@github.com> wrote:

…

Yes, I definitely have no capacity to maintain new plugins, sorry. Was about marking about 15 of my plugins for adoption. If you could just spin a release, it would be great. On Jan 24, 2018 21:32, "Bruno P. Kinoshita" ***@***.***> wrote: > ***@***.**** approved this pull request. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#29# pullrequestreview-91320432>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ AKBqVHABcBoAx5g7utebHc74MrqNzzO5ks5tN5NLgaJpZM4RgHiS> > . > > -- > You received this message because you are subscribed to the Google Groups > "engineering-code-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to ***@***.*** > To post to this group, send email to engineering-code-reviews@ > cloudbees.com. > To view this discussion on the web visit https://groups.google.com/a/ > cloudbees.com/d/msgid/engineering-code-reviews/ jenkinsci/testlink-plugin/ > pull/29/review/91320432%40github.com > <https://groups.google.com/a/cloudbees.com/d/msgid/ engineering-code-reviews/jenkinsci/testlink-plugin/ pull/29/review/91320432%40github.com?utm_medium=email&utm_source=footer> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC3IoGlv7cKmgwKY7sqBorkHeSXIbjR6ks5tN64CgaJpZM4RgHiS> .

kinow · 2018-01-25T00:01:34Z

Sure, works for me @oleg-nenashev.

What about the #25? Is that required as well for a release?

kinow · 2018-01-25T00:09:43Z

Will cut a release as is (and plus #25 if @oleg-nenashev says it needs to be included for this PR) this weekend (this is an extended weekend, with Monday being Auckland anniversary, so will either release Friday night, or Monday evening NZ time).

oleg-nenashev · 2018-01-25T06:32:14Z

I re ommend to release without #25, it needs more reviews imo On Jan 25, 2018 01:09, "Bruno P. Kinoshita" <notifications@github.com> wrote: Will cut a release as is (and plus #25 <#25> if @oleg-nenashev <https://github.com/oleg-nenashev> says it needs to be included for this PR) this weekend (this is an extended weekend, with Monday being Auckland anniversary, so will either release Friday night, or Monday evening NZ time). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC3IoJ57BRXq-fmQ03qaGLA4ScFOXVk3ks5tN8ZLgaJpZM4RgHiS> .

kinow · 2018-01-25T08:27:21Z

Thanks for the quick reply. Had some spare time tonight, enough to cut a new release. Just released it, 3.13 should make the update centre in the next hours I believe.

Let me know if you need anything else, and thanks for working on it 👍
B

oleg-nenashev · 2018-01-25T08:30:40Z

@kinow Thanks a lot, I will update the JEP-200 status page. If you have some time, review/release of jenkinsci/tap-plugin#20 would be great

kinow · 2018-01-25T11:05:06Z

Oh! Was going to forget that one and probably look into that only next week. Merged, preparing a release now :-)

oleg-nenashev added 2 commits January 16, 2018 17:41

Stop serializing Build fields in TestLinkBuildAction and TestLinkResult

d8e49b6

[JENKINS-48924] - Whitelist TestLink Java API classes being used in T…

9bf81a9

…estCaseWrapper

oleg-nenashev requested review from jglick and kinow January 16, 2018 17:12

oleg-nenashev commented Jan 16, 2018

View reviewed changes

[JENKINS-48924] - Forgot some deprecated API

8b93d29

jglick approved these changes Jan 16, 2018

View reviewed changes

oleg-nenashev added 3 commits January 17, 2018 16:40

[JENKINS-48995] - Stop storing TestNG parsers in XML

c3b85cd

[JENKINS-48924] - Whitelist TestNG objects for TestLink

2429714

[JENKINS-48924] - Use MasterToSlaveFileCallable

a92f258

oleg-nenashev changed the title ~~[JENKINS-48924] - Fix plugin compatibility with Jenkins 2.102+~~ [JENKINS-48924, JENKINS-48995] - Fix plugin compatibility with Jenkins 2.102+ Jan 17, 2018

oleg-nenashev requested a review from jglick January 17, 2018 15:53

oleg-nenashev commented Jan 17, 2018

View reviewed changes

oleg-nenashev mentioned this pull request Jan 18, 2018

[JENKINS-48925] - Whitelist safe model classes from the tap4j library jenkinsci/tap-plugin#20

Merged

jglick approved these changes Jan 19, 2018

View reviewed changes

[JENKINS-48924] - Test case is not finished && makes no sense in the …

b56640e

…current state

kinow approved these changes Jan 24, 2018

View reviewed changes

jglick approved these changes Jan 24, 2018

View reviewed changes

kinow merged commit 9d4b1cc into jenkinsci:master Jan 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-48924, JENKINS-48995] - Fix plugin compatibility with Jenkins 2.102+ #29

[JENKINS-48924, JENKINS-48995] - Fix plugin compatibility with Jenkins 2.102+ #29

oleg-nenashev commented Jan 16, 2018 •

edited

Loading

oleg-nenashev Jan 16, 2018

ghost commented Jan 16, 2018

oleg-nenashev commented Jan 16, 2018

oleg-nenashev commented Jan 16, 2018

jglick Jan 16, 2018

oleg-nenashev commented Jan 17, 2018

oleg-nenashev Jan 17, 2018

jglick Jan 19, 2018

oleg-nenashev Jan 19, 2018

jglick Jan 19, 2018

oleg-nenashev Jan 19, 2018

jglick Jan 19, 2018

oleg-nenashev commented Jan 24, 2018

kinow commented Jan 24, 2018

ghost commented Jan 24, 2018 via email

oleg-nenashev commented Jan 24, 2018 via email

kinow commented Jan 25, 2018

kinow commented Jan 25, 2018

oleg-nenashev commented Jan 25, 2018 via email

kinow commented Jan 25, 2018

oleg-nenashev commented Jan 25, 2018

kinow commented Jan 25, 2018

[JENKINS-48924, JENKINS-48995] - Fix plugin compatibility with Jenkins 2.102+ #29

[JENKINS-48924, JENKINS-48995] - Fix plugin compatibility with Jenkins 2.102+ #29

Conversation

oleg-nenashev commented Jan 16, 2018 • edited Loading

Choose a reason for hiding this comment

ghost commented Jan 16, 2018

oleg-nenashev commented Jan 16, 2018

oleg-nenashev commented Jan 16, 2018

Choose a reason for hiding this comment

oleg-nenashev commented Jan 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleg-nenashev commented Jan 24, 2018

kinow commented Jan 24, 2018

ghost commented Jan 24, 2018 via email

oleg-nenashev commented Jan 24, 2018 via email

kinow commented Jan 25, 2018

kinow commented Jan 25, 2018

oleg-nenashev commented Jan 25, 2018 via email

kinow commented Jan 25, 2018

oleg-nenashev commented Jan 25, 2018

kinow commented Jan 25, 2018

oleg-nenashev commented Jan 16, 2018 •

edited

Loading