[JENKINS-40806] tfs plugin PCT issues against 2.19.4 and 2.32.1 #144

varyvol · 2017-01-04T15:54:17Z

Increase parent POM version.
Increase baseline.
Include necessary dependencies.
Include "escape-by-default" property in Jelly files.
Use MasterToSlaveCallable needed in new baseline version.

@yacaovsnc @davidstaheli @mosabua @reviewbybees

… parent POM, baseline version and include some necessary dependencies.

varyvol · 2017-01-04T15:55:49Z

tfs/src/main/java/hudson/plugins/tfs/commands/AbstractCallableCommand.java


 import java.io.IOException;
 import java.io.Serializable;

-public abstract class AbstractCallableCommand implements Serializable {
+public abstract class AbstractCallableCommand<V, T extends Throwable> extends MasterToSlaveCallable<V, T> implements Serializable {


There exists also SlaveToMasterCallable, but I presume this is correct as all tests are working correctly.

varyvol · 2017-01-04T15:57:34Z

pom.xml

    <maven-surefire-plugin.version>2.19.1</maven-surefire-plugin.version>
    <!--  overriding old version from parent to be consistent with the above in this project -->
    <maven-surefire-report-plugin.version>${maven-surefire-plugin.version}</maven-surefire-report-plugin.version>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+    <maven-javadoc-plugin.version>2.8</maven-javadoc-plugin.version>
+    <findbugs.failOnError>false</findbugs.failOnError>


Raised JENKINS-40807 to take care of them.

ghost · 2017-01-11T18:43:32Z

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

varyvol · 2017-01-23T08:33:59Z

@olivierdagenais @davidstaheli @mosabua did you have the opportunity to review this?

varyvol · 2017-02-06T08:11:37Z

@olivierdagenais @davidstaheli @mosabua ping?

varyvol · 2017-03-08T07:44:42Z

@olivierdagenais @davidstaheli @mosabua ping?

olivierdagenais · 2017-03-08T12:42:42Z

I regret to inform you that I have left this project. Try @yacaovsnc

varyvol · 2017-03-08T13:38:28Z

@olivierdagenais thanks for letting me know.

yacaovsnc · 2017-03-10T16:54:11Z

@varyvol Thanks for the pull request. If I understand this pull request correctly, it drops Java 1.6 support and requires Java 7?

There is a bug fix that we'd like to push out first without change the system requirement. We will take a look at this PR soon.

Thanks!

varyvol · 2017-03-14T09:00:46Z

@yacaovsnc it does because the baseline Jenkins versions requires Java 7.

No problem, thanks for the heads up!

yacaovsnc · 2017-03-23T20:52:44Z

Failed tests: 
  FunctionalTest.createLabel:224 expected:<NONE> but was:<INCOMPARABLE>
  FunctionalTest.oldPollingFallback:616 expected:<hudson.scm.PollingResult@434c179e> but was:<hudson.scm.PollingResult@46199519>
  FunctionalTest.upgradeEncodedPassword:666 expected:<NONE> but was:<INCOMPARABLE>
  FunctionalTest.useWebProxyServer:729 expected:<NONE> but was:<INCOMPARABLE>

Tests run: 12, Failures: 4, Errors: 0, Skipped: 1

There are functional test failures with this pull request. We need more time to properly debug and merge this pull request. Thanks for understanding.

… JENKINS-40806

varyvol · 2017-04-03T08:06:22Z

@yacaovsnc how are you executing the tests? I have merged the branch with the actual master and executed the tests with "mvn clean verify" and they seem to be working fine.

yacaovsnc · 2017-04-03T14:28:08Z

I followed this doc.

varyvol · 2017-04-03T15:18:28Z

@yacaovsnc I see. Unfortunately I don't have a TFS to execute these functional tests against.

I am suspecting that maybe the two changes in Server class or the one in RemoteChangesetVersionCommand class should be SlaveToMasterCallable and not MasterToSlaveCallable.

Would it be hard for you to change those and execute the tests?

yacaovsnc · 2017-04-03T15:59:01Z

@varyvol it's scheduled on my backlog to fix those changes. Right now I am tied up with another priority and I will take a look at this soon.

recena · 2017-05-05T10:32:08Z

@yacaovsnc Any news?

yacaovsnc · 2017-05-09T15:34:19Z

@recena working on it today.

varyvol · 2017-05-10T06:28:05Z

@yacaovsnc thanks. Let me know if I can be of any help.

yacaovsnc · 2017-05-10T18:47:18Z

@varyvol The test failure doesn't look like an issue with the Callable changes, but rather a problem with upgrading the Jenkins version.

In Jenkins 1.625, AbstractLazyLoadRunMap.search(final int n, final Direction d) seem are looking for exact matches; while in v1.58, it goes through a "slow path" to find the build from disk. I verified the workspaces on disk, it seems in both versions the builds were fine. Just in AbstractProject.java:1309, when we call "getLastBuild()", we are always getting null.

How could we make search() call return with last build?

yacaovsnc · 2017-05-11T16:07:11Z

Will fix the tests failure in another pr. Had to ignore one test as the project layout seems different and without the 'slow path' code path to find the build on disk, it's hard to change.

varyvol · 2017-05-15T06:50:13Z

@yacaovsnc thanks for investigating and working on this.

[JENKINS-40806] Set escape-by-default property in Jelly files. Update…

2d8e0a6

… parent POM, baseline version and include some necessary dependencies.

varyvol commented Jan 4, 2017

View reviewed changes

Merge branch 'master' of https://github.com/jenkinsci/tfs-plugin into…

cf462d6

… JENKINS-40806

yacaovsnc merged commit ba6cd47 into jenkinsci:master May 11, 2017

yacaovsnc mentioned this pull request May 11, 2017

faking the builds does not work anymore, fix tests related with it #160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-40806] tfs plugin PCT issues against 2.19.4 and 2.32.1 #144

[JENKINS-40806] tfs plugin PCT issues against 2.19.4 and 2.32.1 #144

varyvol commented Jan 4, 2017 •

edited

Loading

varyvol Jan 4, 2017

varyvol Jan 4, 2017

ghost commented Jan 11, 2017

varyvol commented Jan 23, 2017

varyvol commented Feb 6, 2017

varyvol commented Mar 8, 2017

olivierdagenais commented Mar 8, 2017

varyvol commented Mar 8, 2017

yacaovsnc commented Mar 10, 2017

varyvol commented Mar 14, 2017

yacaovsnc commented Mar 23, 2017

varyvol commented Apr 3, 2017

yacaovsnc commented Apr 3, 2017

varyvol commented Apr 3, 2017

yacaovsnc commented Apr 3, 2017

recena commented May 5, 2017

yacaovsnc commented May 9, 2017

varyvol commented May 10, 2017

yacaovsnc commented May 10, 2017

yacaovsnc commented May 11, 2017

varyvol commented May 15, 2017

[JENKINS-40806] tfs plugin PCT issues against 2.19.4 and 2.32.1 #144

[JENKINS-40806] tfs plugin PCT issues against 2.19.4 and 2.32.1 #144

Conversation

varyvol commented Jan 4, 2017 • edited Loading

varyvol Jan 4, 2017

Choose a reason for hiding this comment

varyvol Jan 4, 2017

Choose a reason for hiding this comment

ghost commented Jan 11, 2017

varyvol commented Jan 23, 2017

varyvol commented Feb 6, 2017

varyvol commented Mar 8, 2017

olivierdagenais commented Mar 8, 2017

varyvol commented Mar 8, 2017

yacaovsnc commented Mar 10, 2017

varyvol commented Mar 14, 2017

yacaovsnc commented Mar 23, 2017

varyvol commented Apr 3, 2017

yacaovsnc commented Apr 3, 2017

varyvol commented Apr 3, 2017

yacaovsnc commented Apr 3, 2017

recena commented May 5, 2017

yacaovsnc commented May 9, 2017

varyvol commented May 10, 2017

yacaovsnc commented May 10, 2017

yacaovsnc commented May 11, 2017

varyvol commented May 15, 2017

varyvol commented Jan 4, 2017 •

edited

Loading