Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retrieve the right Jenkinsfile when both PR trait are enabled #282

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

robinsoc
Copy link
Contributor

@robinsoc robinsoc commented Sep 7, 2021

Part of story#18320 native support of pull requests in tuleap branch source jenkins plugin

When the both Pull Request traits are enabled the wrong Jenkinsfile
content was read by Jenkins. The Jenkinsfile from the target branch is
read instead of the origin branch even if the origin branch is
considered as trusted!

How to test:

  • Have the both Tuleap Pull Request traits.
  • Launch the job
    => For each Tuleap PR found, make sure that the right Jenkinsfile is
    read by Jenkins

Part of [story#18320](https://tuleap.net/plugins/tracker/?aid=18320) native support of pull requests in tuleap branch source jenkins plugin

When the both Pull Request traits are enabled the wrong Jenkinsfile
content was read by Jenkins. The Jenkinsfile from the target branch is
read instead of the origin branch even if the origin branch is
considered as trusted!

How to test:
 - Have the both Tuleap Pull Request traits.
 - Launch the job
=> For each Tuleap PR found, make sure that the right Jenkinsfile is
read by Jenkins
@robinsoc robinsoc requested a review from Erwyn September 7, 2021 13:11
@Erwyn Erwyn merged commit e1775eb into master Sep 7, 2021
@Erwyn Erwyn deleted the fix/get-the-right-jenkinsfile branch September 7, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants