Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oelint-adv support #1006

Merged
merged 6 commits into from
Aug 5, 2021
Merged

oelint-adv support #1006

merged 6 commits into from
Aug 5, 2021

Conversation

offa
Copy link
Contributor

@offa offa commented Jul 29, 2021

Adds support for oelint-adv, a linter for OpenEmbedded / Yocto.

Related analysis-model PR: jenkinsci/analysis-model#661

@uhafner should PRs update the supported parser list too?

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this PR is not required anymore since the plugin can now use all parsers from analysis-model automatically. But it is ok to provide one, because then you have an individual symbol.

I will release a new version of analysis-model, then you can update the pom.xml version so that the PR will have not failures anymore.

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #1006 (7f85012) into master (2c7192e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7f85012 differs from pull request most recent head 41da6b4. Consider uploading reports for the commit 41da6b4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1006      +/-   ##
============================================
+ Coverage     77.10%   77.12%   +0.01%     
- Complexity     1601     1602       +1     
============================================
  Files           247      248       +1     
  Lines          5696     5700       +4     
  Branches        416      416              
============================================
+ Hits           4392     4396       +4     
  Misses         1147     1147              
  Partials        157      157              
Impacted Files Coverage Δ
...o/jenkins/plugins/analysis/warnings/OELintAdv.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7331c2d...41da6b4. Read the comment docs.

@offa
Copy link
Contributor Author

offa commented Aug 4, 2021

Analysis model 10.3.0 is integrated, but updating the supported formats file (using ToolsLister) results in a huge diff of the table.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Aug 5, 2021
@uhafner uhafner merged commit 1a74ab1 into jenkinsci:master Aug 5, 2021
@offa offa deleted the oelint-adv branch August 5, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
2 participants