Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oelint-adv support #661

Merged
merged 3 commits into from
Aug 3, 2021
Merged

oelint-adv support #661

merged 3 commits into from
Aug 3, 2021

Conversation

offa
Copy link
Contributor

@offa offa commented Jul 29, 2021

Adds support for oelint-adv, a linter for OpenEmbedded / Yocto.

Related warnings-ng PR: jenkinsci/warnings-ng-plugin#1006

@uhafner should PRs update the supported parser list too?

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Please run the ParserRegistry#main method, then your tool will be automatically added to the list of supported formats.

@offa
Copy link
Contributor Author

offa commented Aug 2, 2021

Thanks, I've updated the PR.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #661 (020e274) into master (400dfa4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     92.52%   92.53%   +0.01%     
- Complexity     2071     2076       +5     
============================================
  Files           305      307       +2     
  Lines          5790     5802      +12     
  Branches        583      583              
============================================
+ Hits           5357     5369      +12     
  Misses          269      269              
  Partials        164      164              
Impacted Files Coverage Δ
...du/hm/hafner/analysis/registry/ParserRegistry.java 100.00% <ø> (ø)
...edu/hm/hafner/analysis/parser/OELintAdvParser.java 100.00% <100.00%> (ø)
.../hafner/analysis/registry/OELintAdvDescriptor.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400dfa4...020e274. Read the comment docs.

@uhafner uhafner merged commit 3744b7f into jenkinsci:master Aug 3, 2021
@offa offa deleted the oelint-adv branch August 4, 2021 05:14
@uhafner uhafner added the enhancement Enhancement of existing functionality label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants