Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Tippy JS #1379

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Oct 5, 2022

Updates the plugin to support the new tooltip framework introduced in core jenkinsci/jenkins#6408

image

Images didn't seem to work for me locally hence the missing image.


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1379 (30bd093) into master (2317123) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1379   +/-   ##
=========================================
  Coverage     79.87%   79.87%           
  Complexity     1453     1453           
=========================================
  Files           252      252           
  Lines          5610     5610           
  Branches        428      428           
=========================================
  Hits           4481     4481           
  Misses          978      978           
  Partials        151      151           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@janfaracik janfaracik changed the title draft: Update for Tippy JS Update for Tippy JS Oct 5, 2022
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the new code both in Jenkins 2.372 and in the PR-6408, look good now. In PR-6408 the tooltips are now even staying in the visible area of the screen, thanks to Popper 🎉!

BTW: the missing symbols are fixed in #1380.

<j:set var="total" value="${it.getTotal(job)}"/>
<j:set var="url" value="${it.getUrl(job)}"/>
<td class="healthReport issues-total"
<j:set var="tooltip">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting feature of jelly! I was not aware that one can put server created HTML in a variable!

@uhafner uhafner merged commit 26ce038 into jenkinsci:master Oct 6, 2022
@uhafner uhafner added bug Bugs or performance problems hacktoberfest Pull requests that participate in Hacktoberfest labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems hacktoberfest Pull requests that participate in Hacktoberfest
Projects
None yet
2 participants