Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sorting by issues column when some entries are missing #1710

Merged
merged 1 commit into from Mar 18, 2024

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Mar 17, 2024

Adds data attribute used by sortable.js. Since data is always a number this guarantees sorting by number of issues will work as expected. Without this change, if one or more entries are missing in the column, alphabetical sort is used
2 > 12 > 1 > 0 > -

Also removes 2 lines of inline JS that is no longer needed, improving CSP compatibility.
Code introduced in 0a5457e8, made redundant in #1379.

Testing done

Manually checked that the column sorting works on my Jenkins instance and tooltip functionality is still OK.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant pull requests, esp. upstream and downstream changes
    Options

@uhafner uhafner added the bug Bugs or performance problems label Mar 17, 2024
@uhafner uhafner merged commit dc92a40 into jenkinsci:main Mar 18, 2024
38 of 41 checks passed
@uhafner
Copy link
Member

uhafner commented Mar 18, 2024

Thanks!

@zbynek zbynek deleted the sortable branch March 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
2 participants