Correct sorting by issues column when some entries are missing #1710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
data
attribute used bysortable.js
. Sincedata
is always a number this guarantees sorting by number of issues will work as expected. Without this change, if one or more entries are missing in the column, alphabetical sort is used2 > 12 > 1 > 0 > -
Also removes 2 lines of inline JS that is no longer needed, improving CSP compatibility.
Code introduced in 0a5457e8, made redundant in #1379.
Testing done
Manually checked that the column sorting works on my Jenkins instance and tooltip functionality is still OK.
Submitter checklist