Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Selenium 4 based acceptance-test-harness #1470

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 13, 2023

Bumps acceptance-test-harness from 5497.vca_4a_876045ce to 5509.v07855a_003fc1.

Release notes

Sourced from acceptance-test-harness's releases.

1.54 - JUnit 4.13 🎉

📦 Dependency updates

📝 Documentation updates

👻 Maintenance

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Update of dependencies java Pull requests that update Maven Java dependencies labels Mar 13, 2023
@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci-acceptance-test-harness-5509.v07855a_003fc1 branch from 3c4c13e to ec0c199 Compare March 17, 2023 22:28
@uhafner
Copy link
Member

uhafner commented Mar 18, 2023

@dependabot rebase

Bumps [acceptance-test-harness](https://github.com/jenkinsci/pom) from 5497.vca_4a_876045ce to 5509.v07855a_003fc1.
- [Release notes](https://github.com/jenkinsci/pom/releases)
- [Changelog](https://github.com/jenkinsci/pom/blob/master/CHANGELOG-old.md)
- [Commits](https://github.com/jenkinsci/pom/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci:acceptance-test-harness
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci-acceptance-test-harness-5509.v07855a_003fc1 branch from ec0c199 to 443630e Compare March 18, 2023 14:17
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1470 (df3b113) into master (cbfe663) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1470      +/-   ##
============================================
+ Coverage     81.72%   81.82%   +0.09%     
- Complexity     1400     1402       +2     
============================================
  Files           247      247              
  Lines          5331     5331              
  Branches        396      396              
============================================
+ Hits           4357     4362       +5     
+ Misses          854      850       -4     
+ Partials        120      119       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jtnord
Copy link
Member

jtnord commented Mar 29, 2023

@uhafner there would appear to be something incorrect in your project setup or environment.
The version won't be in the releases repository as it is a snapshot.

b UI tests
failed yesterday in 8m 10s
2s
2s
1s
7m 39s
24s
Run mvn -V --color always -ntp test --file ui-tests/pom.xml -Dtest=DetailsTabUiTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
Maven home: /usr/share/apache-maven-3.8.8
Java version: 11.0.18, vendor: Eclipse Adoptium, runtime: /usr/lib/jvm/temurin-11-jdk-amd64
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-1034-azure", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
[INFO] 
[INFO] --------------< io.jenkins.plugins:warnings-ng-ui-tests >---------------
[INFO] Building UI Tests of Warnings Plugin UNVERSIONED
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.387 s
[INFO] Finished at: 2023-03-28T12:18:27Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project warnings-ng-ui-tests: Could not resolve dependencies for project io.jenkins.plugins:warnings-ng-ui-tests:jar:UNVERSIONED: Failed to collect dependencies at org.jenkins-ci:acceptance-test-harness:jar:999999-20230323.135212-4: Failed to read artifact descriptor for org.jenkins-ci:acceptance-test-harness:jar:999999-20230323.135212-4: Could not transfer artifact org.jenkins-ci:acceptance-test-harness:pom:999999-20230323.135212-4 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): transfer failed for https://repo.jenkins-ci.org/releases/org/jenkins-ci/acceptance-test-harness/999999-SNAPSHOT/acceptance-test-harness-999999-20230323.135212-4.pom, status: 409 -> [Help 1]

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/ui-tests/pom.xml#L71-L80

@uhafner uhafner changed the title Bump acceptance-test-harness from 5497.vca_4a_876045ce to 5509.v07855a_003fc1 Migrate to Selenium 4 based acceptance-test-harness Mar 30, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 31, 2023

A newer version of org.jenkins-ci:acceptance-test-harness exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@uhafner
Copy link
Member

uhafner commented Apr 1, 2023

@uhafner there would appear to be something incorrect in your project setup or environment. The version won't be in the releases repository as it is a snapshot.

b UI tests
failed yesterday in 8m 10s
2s
2s
1s
7m 39s
24s
Run mvn -V --color always -ntp test --file ui-tests/pom.xml -Dtest=DetailsTabUiTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
Maven home: /usr/share/apache-maven-3.8.8
Java version: 11.0.18, vendor: Eclipse Adoptium, runtime: /usr/lib/jvm/temurin-11-jdk-amd64
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-1034-azure", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
[INFO] 
[INFO] --------------< io.jenkins.plugins:warnings-ng-ui-tests >---------------
[INFO] Building UI Tests of Warnings Plugin UNVERSIONED
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.387 s
[INFO] Finished at: 2023-03-28T12:18:27Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project warnings-ng-ui-tests: Could not resolve dependencies for project io.jenkins.plugins:warnings-ng-ui-tests:jar:UNVERSIONED: Failed to collect dependencies at org.jenkins-ci:acceptance-test-harness:jar:999999-20230323.135212-4: Failed to read artifact descriptor for org.jenkins-ci:acceptance-test-harness:jar:999999-20230323.135212-4: Could not transfer artifact org.jenkins-ci:acceptance-test-harness:pom:999999-20230323.135212-4 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): transfer failed for https://repo.jenkins-ci.org/releases/org/jenkins-ci/acceptance-test-harness/999999-SNAPSHOT/acceptance-test-harness-999999-20230323.135212-4.pom, status: 409 -> [Help 1]

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/ui-tests/pom.xml#L71-L80

Ok, I switched now to the new release and that breaks everything 👎

See GitHu jobs above: https://github.com/jenkinsci/warnings-ng-plugin/actions/runs/4577019077/jobs/8081916367?pr=1470

@uhafner uhafner added tests Enhancement of tests and removed dependencies Update of dependencies java Pull requests that update Maven Java dependencies labels May 22, 2023
@uhafner
Copy link
Member

uhafner commented Dec 22, 2023

Superseded by #1643

@uhafner uhafner closed this Dec 22, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 22, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci-acceptance-test-harness-5509.v07855a_003fc1 branch December 22, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
2 participants