Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65845] Don't link to deleted builds #1659

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jan 12, 2024

The age link should be plain text if the build has been deleted.

@uhafner uhafner added the bug Bugs or performance problems label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (95bacd0) 81.68% compared to head (5ed486f) 81.60%.
Report is 5 commits behind head on main.

Files Patch % Lines
...alysis/core/model/StaticAnalysisLabelProvider.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1659      +/-   ##
============================================
- Coverage     81.68%   81.60%   -0.09%     
+ Complexity     1413     1411       -2     
============================================
  Files           249      249              
  Lines          5379     5386       +7     
  Branches        403      404       +1     
============================================
+ Hits           4394     4395       +1     
- Misses          870      874       +4     
- Partials        115      117       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner marked this pull request as ready for review January 12, 2024 16:54
* the job
*/
public DefaultAgeBuilder(final int currentBuildNumber, final String resultUrl, final Job<?, ?> job) {
this(currentBuildNumber, resultUrl);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
DefaultAgeBuilder.DefaultAgeBuilder
should be avoided because it has been deprecated.
@uhafner uhafner merged commit a971cd0 into main Jan 15, 2024
34 of 35 checks passed
@uhafner uhafner deleted the link-to-existing-builds branch January 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
1 participant