[JENKINS-65845] Don't link to deleted builds

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/IssuesDetail.java

@@ -599,16 +599,16 @@ public String getDisplayName() {
     }
 
     /**
-     * Returns a new sub page for the selected link.
+     * Returns a new subpage for the selected link.
      *
      * @param link
-     *         the link to identify the sub page to show
+     *         the link to identify the subpage to show
      * @param request
      *         Stapler request
      * @param response
      *         Stapler response
      *
-     * @return the new sub page
+     * @return the new subpage
      */
     @SuppressWarnings("unused") // Called by jelly view
     public Object getDynamic(final String link, final StaplerRequest request, final StaplerResponse response) {

plugin/src/main/java/io/jenkins/plugins/analysis/core/model/StaticAnalysisLabelProvider.java

@@ -15,6 +15,7 @@
 import j2html.tags.DomContent;
 
 import org.jvnet.localizer.Localizable;
+import hudson.model.Job;
 import hudson.model.Run;
 
 import io.jenkins.plugins.analysis.core.util.QualityGateStatus;
@@ -115,7 +116,7 @@
      * @return the age builder
      */
     protected DefaultAgeBuilder getAgeBuilder(final Run<?, ?> owner, final String url) {
-        return new DefaultAgeBuilder(owner.getNumber(), url);
+        return new DefaultAgeBuilder(owner.getNumber(), url, owner.getParent());
     }
 
     /**
@@ -170,7 +171,8 @@
         return this;
     }
 
-    @Override @Generated
+    @Override
+    @Generated
     public String toString() {
         return String.format("%s: %s", getId(), getName());
     }
@@ -190,7 +192,8 @@
      * @return the name of the side panel link
      * @deprecated use {@link #getLinkName()}
      */
-    @Deprecated @Generated
+    @Deprecated
+    @Generated
     public String getRawLinkName() {
         if (StringUtils.isNotBlank(name)) {
             return Messages.Tool_Link_Name(name);
@@ -397,28 +400,53 @@
     /**
      * Computes the age of a build as a hyperlink.
      */
+    @SuppressWarnings("DeprecatedIsStillUsed")
     public static class DefaultAgeBuilder implements AgeBuilder {
-        private final int currentBuild;
+        private final int currentBuildNumber;
         private final String resultUrl;
+        @CheckForNull
+        private Job<?, ?> owner;
 
         /**
          * Creates a new instance of {@link DefaultAgeBuilder}.
          *
-         * @param currentBuild
+         * @param currentBuildNumber
          *         number of the current build
          * @param resultUrl
          *         URL to the results
+         * @deprecated use {@link #DefaultAgeBuilder(int, String, Job)}
          */
-        public DefaultAgeBuilder(final int currentBuild, final String resultUrl) {
-            this.currentBuild = currentBuild;
+        @Deprecated
+        public DefaultAgeBuilder(final int currentBuildNumber, final String resultUrl) {
+            this.currentBuildNumber = currentBuildNumber;
             this.resultUrl = resultUrl;
         }
 
+        /**
+         * Creates a new instance of {@link DefaultAgeBuilder}.
+         *
+         * @param currentBuildNumber
+         *         number of the current build
+         * @param resultUrl
+         *         URL to the results
+         * @param job
+         *         the job
+         */
+        public DefaultAgeBuilder(final int currentBuildNumber, final String resultUrl, final Job<?, ?> job) {
+            this(currentBuildNumber, resultUrl);
+
+            this.owner = job;
+        }
+
         @Override
         public String apply(final Integer referenceBuild) {
-            if (referenceBuild >= currentBuild) {
+            if (referenceBuild >= currentBuildNumber) {
                 return "1"; // fallback
             }
+            var referenceBuildId = String.valueOf(referenceBuild);
+            if (owner != null && owner.getBuild(referenceBuildId) == null) {
+                return computeAge(referenceBuild); // plain link
+            }
             else {
                 String cleanUrl = StringUtils.stripEnd(resultUrl, "/");
                 int subDetailsCount = StringUtils.countMatches(cleanUrl, "/");
@@ -432,7 +460,7 @@
         }
 
         private String computeAge(final int buildNumber) {
-            return String.valueOf(currentBuild - buildNumber + 1);
+            return String.valueOf(currentBuildNumber - buildNumber + 1);
         }
     }
 

plugin/src/test/java/io/jenkins/plugins/analysis/core/model/AbstractDetailsModelTest.java

@@ -12,6 +12,7 @@
 import edu.hm.hafner.analysis.IssueBuilder;
 import edu.hm.hafner.analysis.Severity;
 
+import hudson.model.Job;
 import hudson.model.Run;
 
 import io.jenkins.plugins.analysis.core.model.StaticAnalysisLabelProvider.DefaultAgeBuilder;
@@ -96,8 +97,15 @@
      * @return a {@link DefaultAgeBuilder} stub
      */
     protected DefaultAgeBuilder createAgeBuilder() {
-        return new DefaultAgeBuilder(1, "url");
+        return new DefaultAgeBuilder(1, "url", createProject());
+    }
+
+    private Job<?, ?> createProject() {
+        var job = mock(Job.class);
+        var run = mock(Run.class);
+        when(job.getBuild(anyString())).thenReturn(run);
+        return job;
     }
 
     protected void assertThatDetailedColumnContains(final DetailedCell<String> actualColumn,
             final String expectedDisplayName, final String expectedSortOrder) {

plugin/src/test/java/io/jenkins/plugins/analysis/core/model/StaticAnalysisLabelProviderTest.java

@@ -8,11 +8,15 @@
 
 import edu.hm.hafner.analysis.IssueBuilder;
 
+import hudson.model.Job;
+import hudson.model.Run;
+
 import io.jenkins.plugins.analysis.core.model.StaticAnalysisLabelProvider.AgeBuilder;
 import io.jenkins.plugins.analysis.core.model.StaticAnalysisLabelProvider.CompositeLocalizable;
 import io.jenkins.plugins.analysis.core.model.StaticAnalysisLabelProvider.DefaultAgeBuilder;
 
 import static io.jenkins.plugins.analysis.core.assertions.Assertions.*;
+import static org.mockito.Mockito.*;
 
 /**
  * Tests the class {@link StaticAnalysisLabelProvider}.
@@ -97,14 +101,21 @@
     class AgeBuilderTest {
         @Test
         void shouldCreateAgeLinkForFirstBuild() {
-            AgeBuilder builder = new DefaultAgeBuilder(1, "checkstyle/");
+            AgeBuilder builder = new DefaultAgeBuilder(1, "checkstyle/", createProject());
 
             assertThat(builder.apply(1)).isEqualTo("1");
         }
 
+        private Job<?, ?> createProject() {
+            var job = mock(Job.class);
+            var run = mock(Run.class);
+            when(job.getBuild(anyString())).thenReturn(run);
+            return job;
+        }
+
         @Test
         void shouldCreateAgeLinkForPreviousBuilds() {
-            AgeBuilder builder = new DefaultAgeBuilder(10, "checkstyle/");
+            AgeBuilder builder = new DefaultAgeBuilder(10, "checkstyle/", createProject());
             assertThat(builder.apply(1))
                     .isEqualTo("<a href=\"../../1/checkstyle\">10</a>");
             assertThat(builder.apply(9))
@@ -113,9 +124,17 @@
                     .isEqualTo("1");
         }
 
+        @Test @Issue("JENKINS-65845")
+        void shouldCreatePlainTextForDeletedBuilds() {
+            AgeBuilder builder = new DefaultAgeBuilder(10, "checkstyle/", mock(Job.class));
+            assertThat(builder.apply(1)).isEqualTo("10");
+            assertThat(builder.apply(9)).isEqualTo("2");
+            assertThat(builder.apply(10)).isEqualTo("1");
+        }
+
         @Test
         void shouldCreateAgeLinkForSubDetails() {
-            AgeBuilder builder = new DefaultAgeBuilder(10, "checkstyle/package.1234/");
+            AgeBuilder builder = new DefaultAgeBuilder(10, "checkstyle/package.1234/", createProject());
             assertThat(builder.apply(1))
                     .isEqualTo("<a href=\"../../../1/checkstyle\">10</a>");
             assertThat(builder.apply(9))