-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-62944] Add exclude sections for task scanner #682
Conversation
…BEGIN and following, until a line contains IGNORE_END
I have no idea why the UI tests fails. On my machine your PR works. Maybe another plugin causes the problem... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why the UI tests fails. On my machine your PR works. Maybe another plugin causes the problem...
plugin/src/main/java/io/jenkins/plugins/analysis/warnings/tasks/TaskScanner.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/analysis/warnings/tasks/TaskScanner.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/io/jenkins/plugins/analysis/warnings/tasks/TaskScanner.java
Outdated
Show resolved
Hide resolved
…ort parallel checks getting rid of no longer required reset()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks! Please mark as ready for merge.
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
============================================
+ Coverage 80.67% 80.70% +0.03%
- Complexity 1495 1496 +1
============================================
Files 240 240
Lines 5370 5380 +10
Branches 368 371 +3
============================================
+ Hits 4332 4342 +10
Misses 882 882
Partials 156 156
Continue to review full report at Codecov.
|
first draft of a solution for https://issues.jenkins-ci.org/browse/JENKINS-62944
not sure
@uhafner do you have some hints here?