Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-62944] Add exclude sections for task scanner #682

Merged
merged 8 commits into from
Nov 17, 2020

Conversation

ssproessig
Copy link
Contributor

first draft of a solution for https://issues.jenkins-ci.org/browse/JENKINS-62944

not sure

  • if this is enough
  • how and where to document this

@uhafner do you have some hints here?

@uhafner
Copy link
Member

uhafner commented Nov 8, 2020

I have no idea why the UI tests fails. On my machine your PR works. Maybe another plugin causes the problem...

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why the UI tests fails. On my machine your PR works. Maybe another plugin causes the problem...

@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 8, 2020
@uhafner uhafner changed the title Jenkins 62944 [JENKINS-62944] Add exclude sections for task scanner Nov 8, 2020
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks! Please mark as ready for merge.

@ssproessig ssproessig marked this pull request as ready for review November 13, 2020 15:10
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #682 (1092b54) into master (ac18b8a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #682      +/-   ##
============================================
+ Coverage     80.67%   80.70%   +0.03%     
- Complexity     1495     1496       +1     
============================================
  Files           240      240              
  Lines          5370     5380      +10     
  Branches        368      371       +3     
============================================
+ Hits           4332     4342      +10     
  Misses          882      882              
  Partials        156      156              
Impacted Files Coverage Δ Complexity Δ
...s/plugins/analysis/warnings/tasks/TaskScanner.java 92.55% <100.00%> (+0.88%) 29.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac18b8a...1092b54. Read the comment docs.

@uhafner uhafner merged commit b41e456 into jenkinsci:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants