Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-62414] Make all number columns right aligned #760

Merged
merged 3 commits into from
Jan 30, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jan 27, 2021

Set all columns that show numbers to type NUMBER.

See JENKINS-62414.

Downstream PR for jenkinsci/data-tables-api-plugin#144

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #760 (aff56af) into master (f5d9d1a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
+ Coverage     79.73%   79.75%   +0.01%     
  Complexity     1537     1537              
============================================
  Files           243      243              
  Lines          5610     5615       +5     
  Branches        412      412              
============================================
+ Hits           4473     4478       +5     
  Misses          971      971              
  Partials        166      166              
Impacted Files Coverage Δ Complexity Δ
...plugins/analysis/core/model/DetailsTableModel.java 100.00% <100.00%> (ø) 12.00 <1.00> (ø)
...ns/plugins/analysis/core/model/ForensicsModel.java 92.06% <100.00%> (+0.53%) 4.00 <0.00> (ø)
...lugins/analysis/warnings/DuplicateCodeScanner.java 82.02% <100.00%> (+0.20%) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d9d1a...aff56af. Read the comment docs.

@uhafner uhafner merged commit d819bd7 into master Jan 30, 2021
@uhafner uhafner deleted the right-align-columns branch January 30, 2021 20:30
@uhafner uhafner added the enhancement Enhancement of existing functionality label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant