Fix NPE when using serialized Axivion Suite tool in newer versions where new field was not present #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
============================================
- Coverage 80.10% 80.01% -0.10%
- Complexity 1420 1423 +3
============================================
Files 237 237
Lines 5228 5239 +11
Branches 408 411 +3
============================================
+ Hits 4188 4192 +4
- Misses 890 893 +3
- Partials 150 154 +4
Continue to review full report at Codecov.
|
uhafner
requested changes
May 13, 2021
plugin/src/main/java/io/jenkins/plugins/analysis/warnings/axivion/AxivionSuite.java
Show resolved
Hide resolved
arturbosch
force-pushed
the
npe-due-to-serialization
branch
2 times, most recently
from
60d20df
to
2a25f7e
Compare
uhafner
requested changes
May 14, 2021
...rc/test/java/io/jenkins/plugins/analysis/warnings/axivion/AxivionSuiteSerializationTest.java
Outdated
Show resolved
Hide resolved
…ere field was not present
arturbosch
force-pushed
the
npe-due-to-serialization
branch
from
2a25f7e
to
1a6cc28
Compare
uhafner
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uhafner I'm not sure if this is the best fix and how to handle such cases in the future.
In #853 I introduced a new configurable field
namedFilter.As I found out stapler/jelly serializes
Tools between runs. Loading such a serializedToolwill not execute the code which initializes this new field (private String namedFilter = StringUtils.EMPTY;) and will lead to a NPE later on.To avoid this I need to go to the configuration screen and just press save again for a new serialized copy.
The general idea is to check if new fields are null and if yes to patch them in the
runmethod.