-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new status icons in quality gate of pull request portlet #986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
============================================
- Coverage 79.93% 79.87% -0.07%
- Complexity 1413 1447 +34
============================================
Files 237 238 +1
Lines 5199 5306 +107
Branches 406 416 +10
============================================
+ Hits 4156 4238 +82
- Misses 893 911 +18
- Partials 150 157 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice! Thanks.
@simonsymhoven one additional question: the texts "Quality Gate", "Success" and "No issues have been reported" (see screenshots above) seem to be very light when compared to all other texts in Jenkins. Is this intended or is there something broken in the CSS? |
Hmm, at least I didn't consciously change the font settings.. I think there is something broken. |
@uhafner When do you plan to release it? I have a presentation of the pull request monitoring plugin on wednesday, so it would be great if I could show the latest portlets. Thanks! |
Hmm, last night I tried but the release process stopped locally due to some failures during Jenkins startup... I don't think that I find time today to find the reason. |
Internally the quality gate still uses the
BallColor
class to visualize the quality gate status. This class has not been adapted to use the new Jenkins status icons so it is required to use a different way to show the correct icon of the quality gate.Screenshot