Use new status icons in quality gate of pull request portlet

[uhafner]

Internally the quality gate still uses the BallColor class to visualize the quality gate status. This class has not been adapted to use the new Jenkins status icons so it is required to use a different way to show the correct icon of the quality gate.

• Fix status icon in pull request portlet
• Fix status icon in build summary (will be solved in another PR)

Screenshot

[codecov]

Codecov Report

Merging #986 (383e208) into master (0001ba5) will decrease coverage by 0.06%.
The diff coverage is 56.55%.

@@             Coverage Diff              @@
##             master     #986      +/-   ##
============================================
- Coverage     79.93%   79.87%   -0.07%     
- Complexity     1413     1447      +34     
============================================
  Files           237      238       +1     
  Lines          5199     5306     +107     
  Branches        406      416      +10     
============================================
+ Hits           4156     4238      +82     
- Misses          893      911      +18     
- Partials        150      157       +7     

Impacted Files	Coverage Δ
...ugins/analysis/core/columns/IssuesTotalColumn.java	76.04% <0.00%> (ø)
...ins/analysis/core/model/AggregatedTrendAction.java	28.26% <0.00%> (-0.63%)	⬇️
...kins/plugins/analysis/core/model/FilesScanner.java	91.11% <ø> (ø)
...kins/plugins/analysis/core/model/IssuesDetail.java	56.98% <0.00%> (-1.90%)	⬇️
...gins/analysis/core/model/ResetReferenceAction.java	57.14% <ø> (ø)
...kins/plugins/analysis/core/model/ResultAction.java	66.66% <0.00%> (-1.34%)	⬇️
...gins/analysis/core/util/AffectedFilesResolver.java	91.83% <ø> (ø)
...enkins/plugins/analysis/core/util/QualityGate.java	50.48% <ø> (ø)
...lysis/warnings/axivion/RemoteAxivionDashboard.java	0.00% <0.00%> (ø)
...jenkins/plugins/analysis/core/model/JobAction.java	70.58% <7.69%> (-14.78%)	⬇️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d0a5f...383e208. Read the comment docs.

[simonsymhoven]

This looks very nice! Thanks.

[uhafner]

@simonsymhoven one additional question: the texts "Quality Gate", "Success" and "No issues have been reported" (see screenshots above) seem to be very light when compared to all other texts in Jenkins. Is this intended or is there something broken in the CSS?

[simonsymhoven]

@simonsymhoven one additional question: the texts "Quality Gate", "Success" and "No issues have been reported" (see screenshots above) seem to be very light when compared to all other texts in Jenkins. Is this intended or is there something broken in the CSS?

Hmm, at least I didn't consciously change the font settings.. I think there is something broken.

[simonsymhoven]

@uhafner When do you plan to release it? I have a presentation of the pull request monitoring plugin on wednesday, so it would be great if I could show the latest portlets. Thanks!

[uhafner]

Hmm, last night I tried but the release process stopped locally due to some failures during Jenkins startup... I don't think that I find time today to find the reason.