Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding a PipelineTriggersJobProperty unless some triggers were actually configured #42

Merged
merged 4 commits into from
Nov 6, 2017
Merged

Avoid adding a PipelineTriggersJobProperty unless some triggers were actually configured #42

merged 4 commits into from
Nov 6, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 22, 2017

Incorporates #41, without which triggerPresentDuringStart would fail, though I do not think that is mergeable as written.

The idea of this PR is to ensure that in Pipeline Syntax for properties, if you do not select any triggers you will see just

properties([])

and not

properties([pipelineTriggers([])])

@reviewbybees esp. @abayer

scoheb and others added 3 commits March 9, 2017 16:00
@scoheb
Triggers should be started on job creation
47622a0 
[FIXES JENKINS-42446]
@jglick
Avoid adding a PipelineTriggersJobProperty unless some triggers were …
2afa555 
…actually configured.
@jglick
Deleting triggerPresentAndStartedDuringCreate since it is now redundant.
24d24ea 
configRoundtrip is no longer adding an empty property, so it has no effect on reproducibility of the bug.
@jglick jglick mentioned this pull request May 9, 2017
Closed
@abayer abayer mentioned this pull request May 9, 2017
Closed
@jglick jglick mentioned this pull request Jun 22, 2017
Closed
@jglick jglick mentioned this pull request Sep 18, 2017
Merged
1 task
@jglick
Copy link
Member Author

jglick commented Sep 18, 2017

IIRC the actual patch here is independent of #41, but it cannot be sanely tested without that.

@jglick
Copy link
Member Author

jglick commented Oct 23, 2017

Not sure about the impact of #41, but anyway I have made this mergeable again @abayer.

@ghost
Copy link

ghost commented Oct 23, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick requested a review from svanoort October 30, 2017 15:07
abayer
abayer approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@abayer abayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving. =)

@abayer abayer merged commit de5316b into jenkinsci:master Nov 6, 2017
@jglick jglick deleted the empty-PipelineTriggersJobProperty branch November 21, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer abayer approved these changes

@svanoort svanoort Awaiting requested review from svanoort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @abayer @scoheb