Missing N or O in AMD Group: Keep going #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print a warning but don't fail if the N or O atoms are missing in an amide group. This is consistent with how other groups handle missing atoms. Closes #17
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 73.09% 73.04% -0.05%
==========================================
Files 24 24
Lines 3958 3962 +4
==========================================
+ Hits 2893 2894 +1
- Misses 1065 1068 +3
Continue to review full report at Codecov.
|
sobolevnrm
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a warning but don't fail if the N or O atoms are missing in an amide group.
Not sure if this is the best solution, but it's consistent with how other groups handle missing atoms (
COOGroup,HISGroup).Closes #17