Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python support. #156

Merged
merged 4 commits into from
Feb 5, 2023
Merged

Update Python support. #156

merged 4 commits into from
Feb 5, 2023

Conversation

sobolevnrm
Copy link
Collaborator

Remove 3.6 and change Change Log.

Fixes #154

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 73.05% // Head: 73.08% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (72c4950) compared to base (01bf46c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   73.05%   73.08%   +0.02%     
==========================================
  Files          24       25       +1     
  Lines        3968     3972       +4     
==========================================
+ Hits         2899     2903       +4     
  Misses       1069     1069              
Impacted Files Coverage Δ
propka/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sobolevnrm sobolevnrm requested review from IAlibay and speleo3 and removed request for IAlibay January 29, 2023 22:55
@sobolevnrm
Copy link
Collaborator Author

@speleo3 and @IAlibay do you want to review this before I merge? It's a pretty simple change.

docs/source/changelog.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, just had the one comment above.

Make corresponding changes to other files (including a few that I
missed before).
Copy link
Contributor

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's a Sunday evening and I'm not thinking things through - setup.py needs to be updated accordingly.

@sobolevnrm
Copy link
Collaborator Author

Sorry it's a Sunday evening and I'm not thinking things through - setup.py needs to be updated accordingly.

Thanks; see 74b8425.

setup.py Show resolved Hide resolved
Copy link
Contributor

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sobolevnrm
Copy link
Collaborator Author

Thanks!

Copy link
Collaborator

@speleo3 speleo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sobolevnrm sobolevnrm merged commit 430b631 into master Feb 5, 2023
@sobolevnrm sobolevnrm deleted the nathan/154 branch February 5, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub action-based testing is failing
3 participants