Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo? #27

Closed
mkrompiec opened this issue Oct 26, 2021 · 2 comments
Closed

typo? #27

mkrompiec opened this issue Oct 26, 2021 · 2 comments

Comments

@mkrompiec
Copy link

python xyz2mol.py examples/acetate.xyz --charge -1

Traceback (most recent call last):
  File "/Users/michalkrompiec/xyz2mol/xyz2mol/xyz2mol.py", line 806, in <module>
    mols = xyz2mol(atoms, xyz_coordinates,
  File "/Users/michalkrompiec/xyz2mol/xyz2mol/xyz2mol.py", line 732, in xyz2mol
    for new_mol in new_mols:
NameError: name 'new_mols' is not defined

Looks like there is a typo in line 725 (introduced by the commit on Oct 2), which should be changed to:
new_mols = AC2mol(mol, AC, atoms, charge,

@nbehrnd
Copy link

nbehrnd commented Jan 2, 2022

Possibly related to the observation by @mkrompiec, xyz2mol.py by commit 2021-10-02 (d78ab4d0) does not function in the anticipated way. One that does work however is the earlier commit by Jan H. Hensen (2020-11-26, 08:36, ac47bce, «charge check in AC2mol») easily checked-out.

Actually, Linux Debian 12/bookworm (branch testing) provides all to resolve the dependencies to work with xyz2mol. This includes RDKit; thankfully, the repackaged version provided by DebiChem corresponds to version 2021.09.2 (tracker)).

@nbehrnd nbehrnd mentioned this issue Jan 2, 2022
@jhjensen2
Copy link
Member

Sorry for the long delay on this! Typo is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants