Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blame functionality is not quite like real blame #47

Open
rchl opened this issue May 25, 2013 · 4 comments
Open

Blame functionality is not quite like real blame #47

rchl opened this issue May 25, 2013 · 4 comments

Comments

@rchl
Copy link
Collaborator

rchl commented May 25, 2013

blame (b) in the changeset view works as expected for lines that were modified in this commit but for all other lines it will just point to the parent commit, instead of like real git blame, pointing to the commit that modified the line.

@jensl
Copy link
Owner

jensl commented May 26, 2013

This is what it is designed to do, yes. In particular, in a "squashed diff" it is meant to tell you which of the contributing commits contributed what change. This means of course that it is rather pointless in its current form on a single-commit diff, and should really be disabled there.

@rchl
Copy link
Collaborator Author

rchl commented May 26, 2013

Or just show it for the lines that have blame markers, whether in single commit view or not. I think it worked like that some time before...

@jensl
Copy link
Owner

jensl commented May 26, 2013

You mean disable the tooltips that blames the parent commit? Yeah, that'd make sense, I guess.

@jensl
Copy link
Owner

jensl commented May 26, 2013

Although I'm pretty sure it never worked that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants